Skip to content

Conversation

frostiq
Copy link
Contributor

@frostiq frostiq commented Jan 8, 2019

No description provided.

@frostiq
Copy link
Contributor Author

frostiq commented Jan 11, 2019

Could you please help me to fix this CI error?

$ prettier --list-different '**/*.ts'
lib/targets/ethers/generation.ts
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@krzkaczor
Copy link
Member

@frostiq have you tried running ‘yarn test:fix’? It should run formatting in fix mode.

@coveralls
Copy link

coveralls commented Jan 11, 2019

Pull Request Test Coverage Report for Build 176

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 88.504%

Totals Coverage Status
Change from base Build 172: 0.02%
Covered Lines: 392
Relevant Lines: 427

💛 - Coveralls

@frostiq
Copy link
Contributor Author

frostiq commented Jan 11, 2019

Thanks, @krzkaczor, it helped! :)
Pls take a look at my pr

@krzkaczor
Copy link
Member

@frostiq sorry for the delay. Good job 👍 PR looks good but we would need at least one test here. Like passing this new argument somewhere in tests to make sure that everything works correctly.

@frostiq
Copy link
Contributor Author

frostiq commented Jan 14, 2019

Sure, no prob @krzkaczor
I've added a test for transaction overrides

@krzkaczor krzkaczor merged commit d62a31d into dethcrypto:master Jan 14, 2019
@krzkaczor
Copy link
Member

Thanks for your contribution @frostiq! I am gonna release it in a sec.

@krzkaczor
Copy link
Member

Released as: typechain@0.3.11

@frostiq
Copy link
Contributor Author

frostiq commented Jan 14, 2019

Thanks, @krzkaczor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants