Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-4844: Add explicit requirement of correct version byte for every versioned hash in blob txs #7014

Closed
wants to merge 1 commit into from

Conversation

marioevz
Copy link
Member

Adds explicit requirement of BLOB_COMMITMENT_VERSION_KZG byte at the start of every versioned hash in blob transactions for a block to be considered valid during execution.

Adds explicit requirement of `BLOB_COMMITMENT_VERSION_KZG` byte at the start of every versioned hash in blob transactions for a block to be considered valid during execution.
@marioevz marioevz requested a review from eth-bot as a code owner May 11, 2023 15:31
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels May 11, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 11, 2023

File EIPS/eip-4844.md

Requires 1 more reviewers from @adietrichs, @asn-d6, @dankrad, @Inphi, @lightclient, @protolambda, @vbuterin

@eth-bot eth-bot changed the title EIP-4844: Add explicit requirement of correct version byte for every versioned hash in blob txs Update EIP-4844: Add explicit requirement of correct version byte for every versioned hash in blob txs May 11, 2023
@eth-bot eth-bot added the a-review Waiting on author to review label May 11, 2023
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per ACD and the last 4844 call, this is good!

@lightclient
Copy link
Member

closed via #7038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants