Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly celebrate the merge #24543

Closed
wants to merge 1 commit into from
Closed

Properly celebrate the merge #24543

wants to merge 1 commit into from

Conversation

m1guelpf
Copy link

@m1guelpf m1guelpf commented Mar 16, 2022 •
edited
Loading

As people watching the Klin merge stream commented on, the moment where we finally merge should have a lil more celebration 🙃

Other suggestions for what to say are also welcome. Could also add some extra whitespace for visual separation.

(note) Really really appreciate everyone's insane work on this, and sorry for the time it'll take to review this. Keep up the good work <3

@m1guelpf m1guelpf requested a review from karalabe as a code owner March 16, 2022 02:17
sporkspatula
sporkspatula reviewed Mar 16, 2022
View reviewed changes
Copy link

@sporkspatula sporkspatula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hugo0
Copy link

Hugo0 commented Mar 16, 2022

Lmao

At least delete one of the logs, it's redundant to have both

@staringispolite
Copy link

staringispolite commented Mar 16, 2022 •
edited
Loading

Would also have accepted

< log.Info("Left PoW stage")
> log.Info("Exit PoW, stage left")

@odyslam
Copy link
Contributor

odyslam commented Mar 16, 2022 

          .         .                                                                                             
         ,8.       ,8.          8 8888888888   8 888888888o.      ,o888888o.    8 8888888888   8 888888888o.      
        ,888.     ,888.         8 8888         8 8888    `88.    8888     `88.  8 8888         8 8888    `^888.   
       .`8888.   .`8888.        8 8888         8 8888     `88 ,8 8888       `8. 8 8888         8 8888        `88. 
      ,8.`8888. ,8.`8888.       8 8888         8 8888     ,88 88 8888           8 8888         8 8888         `88 
     ,8'8.`8888,8^8.`8888.      8 888888888888 8 8888.   ,88' 88 8888           8 888888888888 8 8888          88 
    ,8' `8.`8888' `8.`8888.     8 8888         8 888888888P'  88 8888           8 8888         8 8888          88 
   ,8'   `8.`88'   `8.`8888.    8 8888         8 8888`8b      88 8888   8888888 8 8888         8 8888         ,88 
  ,8'     `8.`'     `8.`8888.   8 8888         8 8888 `8b.    `8 8888       .8' 8 8888         8 8888        ,88' 
 ,8'       `8        `8.`8888.  8 8888         8 8888   `8b.     8888     ,88'  8 8888         8 8888    ,o88P'   
,8'         `         `8.`8888. 8 888888888888 8 8888     `88.    `8888888P'    8 888888888888 8 888888888P'

@karalabe
Copy link
Member

Though if the merge fails after printing a yuge celebratory message, that's gonna be an epic self burn :P

@odyslam
Copy link
Contributor

odyslam commented Mar 16, 2022 

log.warn("                                                                
8 8888888888   8 8888      88     ,o888888o.    8 8888     ,88' 
8 8888         8 8888      88    8888     `88.  8 8888    ,88'  
8 8888         8 8888      88 ,8 8888       `8. 8 8888   ,88'   
8 8888         8 8888      88 88 8888           8 8888  ,88'    
8 888888888888 8 8888      88 88 8888           8 8888 ,88'     
8 8888         8 8888      88 88 8888           8 8888 88'      
8 8888         8 8888      88 88 8888           8 888888<       
8 8888         ` 8888     ,8P `8 8888       .8' 8 8888 `Y8.     
8 8888           8888   ,d8P     8888     ,88'  8 8888   `Y8.   
8 8888            `Y88888P'       `8888888P'    8 8888     `Y8. 
")

holiman
holiman reviewed Mar 16, 2022
View reviewed changes
consensus/merger.go
@@ -73,6 +73,7 @@ func (m *Merger) ReachTTD() {
}
rawdb.WriteTransitionStatus(m.db, blob)
log.Info("Left PoW stage")
log.Info("WE JUST MERGED LFGGGGGGGGGGGGG")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh. This isn't classy, IMO.
I'd rather go for something more subtle. Some unicode emoticon, or maybe some quote, or maybe some fine ascii art.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐼🐼🐼

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"A small step for a man, a huge leap for mankind"
"The internet of money should not cost $0.05 per transaction - @vbuterin"
"Ethereum ESG ETF incoming"
"I don't believe a second, compatible implementation of Bitcoin will ever be a good idea - Satoshi Nakomoto"

@karalabe
Copy link
Member

Ok, this discussion is going nowhere fast. Going to close this and we'll see if we'll do something about it or not. Thanks for the suggestion though!

@karalabe karalabe closed this Mar 16, 2022
@m1guelpf m1guelpf deleted the patch-1 branch March 16, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden left review comments

@holiman holiman holiman left review comments

@sporkspatula sporkspatula sporkspatula approved these changes

@gtspencer gtspencer gtspencer approved these changes

@scotato scotato scotato approved these changes

@karalabe karalabe Awaiting requested review from karalabe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@m1guelpf @Hugo0 @staringispolite @odyslam @karalabe @holiman @scotato @gtspencer @MariusVanDerWijden @sporkspatula