Skip to content

refactor: static analyser plugin from yo-yo to react #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 110 commits into from
May 12, 2021
Merged

refactor: static analyser plugin from yo-yo to react #1104

merged 110 commits into from
May 12, 2021

Conversation

@tizah
Copy link
Contributor

@tizah tizah commented Apr 10, 2021 •
edited by ioedeveloper
Loading

[ Definition of Done ] :

  • The static analysis plugin, currently built with yo-yo framework should be re-written in Reactjs.

Additional Improvements

  • Change default checkbox to custom checkbox used in settings tab and terminal.
  • Make title of category content bold and increase space below description.
  • Make panels separately collapsible and remove accordion
  • Add select all for each category in static analysis tab.

Related issues

#186
#212

https://www.loom.com/share/fff9abaa363f4f509ac6294b2a837d86

@tizah tizah linked an issue Apr 10, 2021 that may be closed by this pull request
Move Static Analysis Tab To Reactjs #985
Closed
5 tasks
davidzagi and others added 22 commits April 12, 2021 12:51
@davidzagi
added warning sign when analysis has runned
b829de8
@davidzagi
removed icon: fas fa-angle-double-right from each category display name
e765dd6
@tizah
Merge branch 'master' into refactoring-static-analyser
74404c3
@tizah
adding a condition to fix ci build
84bcd82
@tizah
Merge branch 'master' into refactoring-static-analyser
a053eef
@tizah
fix: testing to see if test passes
edf19b4
@tizah
Merge branch 'refactoring-static-analyser' of https://github.com/ethe…
c22fa5e 
…reum/remix-project into refactoring-static-analyser
@tizah
added className staticAnalysisView to staticAnalyser component
3d8d939
@tizah
remove className staticAnalysisView and added id = staticanalysisView
15b599c
@tizah
fix: moved staticanalysisButton id to the Button component
47100bd
@tizah
Merge branch 'master' into refactoring-static-analyser
f04fa3c
@tizah
fix: removed disabled props on button
9c2bc3a
@tizah
Merge branch 'refactoring-static-analyser' of https://github.com/ethe…
60df389 
…reum/remix-project into refactoring-static-analyser
@tizah
reversed changes
1a595bf
@tizah
commiting code to detect failing test
81b7e38
@tizah
removed comments
ba090e2
@tizah
removing comments and unused functions
d351f4c
@tizah
removed extra space at end of file
973de43
@tizah
added new line at end of file
a34e01c
@tizah
added new line at end of file
cacfc5c
@tizah
restored staticAnalysis.spec.ts to it previous code structure
845cb3b
@tizah
fix failing test
18cb9d4
@tizah tizah self-assigned this Apr 20, 2021
@tizah tizah added the ready label Apr 20, 2021
@github-actions
Copy link

github-actions bot commented May 10, 2021

Rebase of head ref refactoring-static-analyser on base ref master failed. Conflicts must be resolved manually.

2 similar comments
@github-actions
Copy link

github-actions bot commented May 10, 2021

Rebase of head ref refactoring-static-analyser on base ref master failed. Conflicts must be resolved manually.

@github-actions
Copy link

github-actions bot commented May 10, 2021

Rebase of head ref refactoring-static-analyser on base ref master failed. Conflicts must be resolved manually.

@github-actions
Copy link

github-actions bot commented May 11, 2021

Rebase of head ref refactoring-static-analyser on base ref master failed. Conflicts must be resolved manually.

2 similar comments
@github-actions
Copy link

github-actions bot commented May 11, 2021

Rebase of head ref refactoring-static-analyser on base ref master failed. Conflicts must be resolved manually.

@github-actions
Copy link

github-actions bot commented May 12, 2021

Rebase of head ref refactoring-static-analyser on base ref master failed. Conflicts must be resolved manually.

@github-actions
Copy link

github-actions bot commented May 12, 2021

Rebase of head ref refactoring-static-analyser on base ref master failed. Conflicts must be resolved manually.

@github-actions
Copy link

github-actions bot commented May 12, 2021

Rebase of head ref refactoring-static-analyser on base ref master failed. Conflicts must be resolved manually.

@LianaHus
Copy link
Contributor

LianaHus commented May 12, 2021

"Please reload Remix after having saved the token." is still there. is this problem solved?

@LianaHus
Copy link
Contributor

LianaHus commented May 12, 2021

"Please reload Remix after having saved the token." is still there. is this problem solved?

Sorry wrong PR

@ioedeveloper ioedeveloper merged commit 4af124d into master May 12, 2021
@ioedeveloper ioedeveloper deleted the refactoring-static-analyser branch May 12, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryestew ryestew ryestew approved these changes

@yann300 yann300 yann300 approved these changes

@ioedeveloper ioedeveloper ioedeveloper approved these changes

@Aniket-Engg Aniket-Engg Awaiting requested review from Aniket-Engg

+1 more reviewer

@LianaHus LianaHus LianaHus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tizah tizah

Labels

autorebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move Static Analysis Tab To Reactjs

7 participants

@tizah @ioedeveloper @LianaHus @ryestew @yann300 @davidzagi