Skip to content

Fixed settings tab #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 6, 2021
Merged

Fixed settings tab #1353

merged 4 commits into from
Jul 6, 2021

Conversation

@ioedeveloper
Copy link
Collaborator

@ioedeveloper ioedeveloper commented Jul 5, 2021 •
edited
Loading

Fixes #1349

@bunsenstraat
Copy link
Collaborator

bunsenstraat commented Jul 6, 2021 •
edited
Loading

Clear the localstorage in icognito and reload:

  • no modal anymore
  • an error in console

Screenshot 2021-07-06 at 12 57 28

@ioedeveloper
Copy link
Collaborator Author

ioedeveloper commented Jul 6, 2021 •
edited
Loading

Clear the localstorage in icognito and reload:

* no modal anymore

* an error in console

Screenshot 2021-07-06 at 12 57 28

The modal is only expected to show for matomo tracked urls (alpha, beta and live). It should work after merge. Or you can test it by disabling the url check locally.

@bunsenstraat
Copy link
Collaborator

bunsenstraat commented Jul 6, 2021

Ok I disabled url check:

  • clear storage
  • load icognito
  • the warning still appears
  • click 'sure', the settings is updated,
  • but on reload it keeps showing me the modal also if I decline

tizah
tizah approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@tizah tizah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,

@ioedeveloper ioedeveloper merged commit 0242703 into master Jul 6, 2021
@ioedeveloper ioedeveloper deleted the fix-settings branch July 6, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bunsenstraat bunsenstraat Awaiting requested review from bunsenstraat

@LianaHus LianaHus Awaiting requested review from LianaHus

1 more reviewer

@tizah tizah tizah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't close Matamo modal

4 participants

@ioedeveloper @bunsenstraat @tizah