Skip to content

Conversation

@joeizang
Copy link
Collaborator

Fix bug where dgit doesn't show any badge when others show. Example solidity compiler and static analysis show badges to mention a few.

@joeizang joeizang self-assigned this Dec 28, 2021
@joeizang joeizang requested review from bunsenstraat and removed request for bunsenstraat December 28, 2021 21:21
@yann300
Copy link
Contributor

yann300 commented Dec 29, 2021

seems like there is no commit in this PR.

@ryestew
Copy link
Collaborator

ryestew commented Dec 30, 2021

Is this PR addressing:

  1. making the icons scroll when the space is filled up? - if so - it took about 30 seconds or a minute for the icons to become scroll-able. I think I had that problem before.
  2. making the chevrons clickable to do the scroll with a click - I don't think it is part of this PR (clicking the cevrons doesn't do anything)

@joeizang
Copy link
Collaborator Author

joeizang commented Dec 30, 2021

Is this PR addressing:

  1. making the icons scroll when the space is filled up? - if so - it took about 30 seconds or a minute for the icons to become scroll-able. I think I had that problem before.
  2. making the chevrons clickable to do the scroll with a click - I don't think it is part of this PR (clicking the cevrons doesn't do anything)

No, I think I will work as we agreed where if this is satisfactory for @bunsenstraat then I will move on to these issues. Especially point 2. I created a fix that might have fixed point 1. here

@github-actions
Copy link

@ryestew
Copy link
Collaborator

ryestew commented Dec 30, 2021

this works for me!

Copy link
Collaborator

@bunsenstraat bunsenstraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it, but it seems if there are two plugins both should have badges.
for example try dgit and solhint. compile a file. @ryestew that's how you can test.
if you compile a file solhint should have badges and dgit should show badges too.

@joeizang
Copy link
Collaborator Author

I tried it, but it seems if there are two plugins both should have badges. for example try dgit and solhint. compile a file. @ryestew that's how you can test. if you compile a file solhint should have badges and dgit should show badges too.

I am looking at it now.

@LianaHus
Copy link
Contributor

LianaHus commented Jan 3, 2022

I reviewed the PR. when I start to add plugins first there is a gap after Plugin manager, after a couple of icons, this gap is being filled.
I would suggest fixing this and instead of adding space or gab after Plugin manager to have a fine line.

@joeizang joeizang force-pushed the fix-verticalIcons-badge branch from 746d02a to 46298fc Compare January 3, 2022 12:44
@joeizang
Copy link
Collaborator Author

joeizang commented Jan 3, 2022

I reviewed the PR. when I start to add plugins first there is a gap after Plugin manager, after a couple of icons, this gap is being filled. I would suggest fixing this and instead of adding space or gab after Plugin manager to have a fine line.

Ok...but that will have to be in a separate PR as this addresses a specific issue. I will see if I can add this fix here or create a PR for it later after this is done.

@joeizang joeizang requested a review from bunsenstraat January 3, 2022 13:03
@joeizang joeizang added publish and removed publish labels Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

@joeizang joeizang force-pushed the fix-verticalIcons-badge branch from 8f91cdf to 2ee0d01 Compare January 3, 2022 13:22
@joeizang joeizang added publish and removed publish labels Jan 3, 2022
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Copy link
Collaborator

@bunsenstraat bunsenstraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add plugin get badges, then deactivate the plugin and re-activate the plugin the badges are not there anymore.

@joeizang joeizang force-pushed the fix-verticalIcons-badge branch from 1392db5 to b757303 Compare January 6, 2022 10:45
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

@LianaHus LianaHus requested a review from ryestew January 7, 2022 13:11
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

@bunsenstraat bunsenstraat self-assigned this Jan 10, 2022
@bunsenstraat bunsenstraat requested a review from LianaHus January 10, 2022 08:09
@bunsenstraat bunsenstraat force-pushed the fix-verticalIcons-badge branch from 0603c13 to 62222eb Compare January 11, 2022 15:56
@bunsenstraat bunsenstraat merged commit abcf691 into master Jan 11, 2022
@bunsenstraat bunsenstraat deleted the fix-verticalIcons-badge branch January 11, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants