-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix vertical icons badge #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vertical icons badge #1861
Conversation
|
seems like there is no commit in this PR. |
|
Is this PR addressing:
|
No, I think I will work as we agreed where if this is satisfactory for @bunsenstraat then I will move on to these issues. Especially point 2. I created a fix that might have fixed point 1. here |
|
ipfs://QmWWZRnNbJ3o82KyingzcK4HEVkSA7wB2BxjgpMeLD4eDB |
|
this works for me! |
bunsenstraat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it, but it seems if there are two plugins both should have badges.
for example try dgit and solhint. compile a file. @ryestew that's how you can test.
if you compile a file solhint should have badges and dgit should show badges too.
I am looking at it now. |
|
I reviewed the PR. when I start to add plugins first there is a gap after Plugin manager, after a couple of icons, this gap is being filled. |
746d02a to
46298fc
Compare
Ok...but that will have to be in a separate PR as this addresses a specific issue. I will see if I can add this fix here or create a PR for it later after this is done. |
|
ipfs://Qmc5ULaKsrZgXYdpfQjuBvy6d2TvRFz1GJaiJyvyUGbrop |
8f91cdf to
2ee0d01
Compare
|
ipfs://Qmf4GqaiBFH9ZYKYkbPBqgjLqENLSHcNZbiMN3TBmCJ6ve |
|
ipfs://QmYJa1GmVvLe1imHBhH6vk8UGwWMohVs2D2bDThmdB79ip |
bunsenstraat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you add plugin get badges, then deactivate the plugin and re-activate the plugin the badges are not there anymore.
1392db5 to
b757303
Compare
|
ipfs://QmUTsj6ARdVCMLrXQR77VpKm9bSnaKiGyJtAyqB4hkKRR3 |
|
ipfs://QmRS9veY5qAUJLh3p2aLfDfs9S1hefP1H7cxKxUDddwwEN |
…to fix-verticalIcons-badge
0603c13 to
62222eb
Compare
Fix bug where dgit doesn't show any badge when others show. Example solidity compiler and static analysis show badges to mention a few.