Skip to content

Conversation

jacqueswww
Copy link
Contributor

- What I did

- How I did it

- How to verify it

- Description for the changelog

- Cute Animal Picture

@nrryuya
Copy link
Contributor

nrryuya commented Sep 27, 2018

IMO, this modification is needed?

    def do_OPTIONS(self):
        self.send_response(200)
        self.send_cors_all()
        self.send_header("Access-Control-Allow-Headers", "X-Requested-With, Content-type")
        self.end_headers()

I just tried only with google chrome, though.

@jacqueswww
Copy link
Contributor Author

OK cool, I will add to send_cors_all ;)

@jacqueswww jacqueswww merged commit 384e9f0 into vyperlang:master Sep 27, 2018
@nrryuya
Copy link
Contributor

nrryuya commented Sep 28, 2018

In OPTIONS it should response I think? like

 def do_OPTIONS(self):
        self.send_response(200)
        self.send_cors_all()
        self.end_headers()

@jacqueswww
Copy link
Contributor Author

Is it complaining about not having a response code?

@nrryuya
Copy link
Contributor

nrryuya commented Sep 28, 2018

Yes, when I did a experiment without response code with Chrome, ERR_INVALID_HTTP_RESPONSE occurs.
(Sorry for not explaining enough)

@jacqueswww jacqueswww changed the title Add Access-Control-Allow-Origin: * to all vyper-server requests. Add Access-Control-Allow-Origin: * to all vyper-serve requests. Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants