V4 tracker #479

s1na · 2019-03-22T07:36:36Z

This PR tracks the changes planned for v4 (see #455). It also acts as a base branch for the pull requests, to prevent mixing experimental development in master. This'd allow us to maintain v3, fix bugs and do releases independently of the changes made here, and also have parallel release candidates for v4.

coveralls · 2019-03-22T07:59:06Z

Coverage decreased (-0.3%) to 94.95% when pulling 00f99c2 on v4 into 068db32 on master.

* Bump version to 4 * Upgrade babel to 7, use transform-runtime plugin * evm: add Interpreter class (alternative to runCall) * evm: add Loop, a promisified version of runCode * evm: execute opFn calls through interpreter * evm/loop: mv pc range check out of hot loop * evm: use Interpreter and Loop in runCall and runCode * evm: use promisified state in interpreter and loop * evm/loop: break run into initRunState, runStep, handleOp, getOpHandler * evm/loop: minor fix * test: drop test cases assuming runCall * evm: use util.promisify package * evm: Mv some logic from executeMessage to private methods * Fix linting errors

* evm: add EEI class, use in opFns to get env values * evm: add selfdestruct, finish, revert and useGas to eei * evm: use storageStore, log eei methods in opFns * evm: add call method to eei, fix getAddress * evm: store selfdestructs in txRunState * evm: add callCode method to eei * evm: add callStatic, callDelegate methods to eei * eei: get isStatic from env * eei: refactor getting code in callCode, callDelegate * evm: refactor gas and output in call opFns * opFns: replace subGas with eei.useGas * eei: add create and create2 * evm: pass txRunState to loop in runCode * Fix linting error * Revert moving selfdestruct to txRunState

lib/evm/interpreter.js

holgerd77 · 2019-04-08T08:13:40Z

lib/evm/interpreter.js

+const PStateManager = require('../state/promisified')
+
+module.exports = class Interpreter {
+  constructor (vm, txContext, block, storageReader) {


General note: I think every access through _vm here is an indicator that we have some misplacement of code or suboptimal structure.

* Detach list of precompiles from VM * evm: add getPrecompile method to interpreter

* Promisify runTx internals * Fix linting error

* Drop babel deps, add initial typescript config * Add prettier as dep, add format scripts * Mv bloom/index.js to bloom/index.ts * Migrate bloom to ts, limit its api to buffers * Mv lib/evm/stack.js to lib/evm/stack.ts * Migrate stack to ts, limit it to BN * Mv lib/evm/memory.js to lib/evm/memory.ts * Migrate evm memory to ts * Build:dist before coverage and api browser tests * Use tester dist flag for coverage tests

* Mv lib/state/promisified.js to lib/state/promisified.ts * Change state file types to ts * Migrate state module to ts

no-1ne · 2019-05-14T10:32:39Z

Looks like v4 release is on the horizon. Looking forward to it.

Visiting the repo after long time & you have made awesome strides with ethereum VM in JS, making ethereum development very smooth and hopefully helping blockchain reach its true potential

holgerd77 · 2019-05-14T11:42:32Z

@startupgurukul thanks! 😀

* Change runCode filetype to ts * Migrate runCode to ts

* Change runCall filetype to ts * Migrate runCall to ts

* Change runTx filetype to ts * Migrate runTx to ts

* Change runBlock filetype to ts * Migrate runBlock to ts

* Change runBlockchain filetype to ts * Migrate runBlockchain to ts

* Use typescript configs * Fix tslint errors * Add prettier config * Fix formatting errors

holgerd77 · 2019-05-25T06:46:18Z

@s1na if you feel comfortable with that I would suggest we try to do the master merge here on Monday and do subsequent cleanup work towards the master branch. Then we have two days where the dust can settle on the master branch and we see through a bit again on Wednesday. 😄 😋

Can you do some master rebase here (this would be the procedure, right?)?

Let me know if you have any reservations, in doubt we are not completely bound to this date in any way and should rather make sure that the process is robust and we are confident with the integration work.

s1na · 2019-05-27T10:10:23Z

That sounds good to me. Only would it be okay if I merge master into this branch, and later on we merge v4 into master (instead of rebase)? Due to the large number of commits, and because there are conflicts with master, rebasing can get difficult. I also took care to squash and merge the PRs, so we don't have tons of minor commits polluting the commit history.

holgerd77 · 2019-05-27T10:33:32Z

Ok, that sounds good!

lgtm-com · 2019-05-27T11:18:43Z

This pull request introduces 1 alert and fixes 1 when merging 074c0b1 into 068db32 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless conditional

Comment posted by LGTM.com

lgtm-com · 2019-05-27T11:25:10Z

This pull request introduces 1 alert and fixes 1 when merging 00f99c2 into 068db32 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless conditional

Comment posted by LGTM.com

s1na · 2019-05-27T11:39:37Z

I have merged master into v4. Should be ready for evaluation and merging 😄

holgerd77

Hooray!!! 🎉 🎉 🎉

This might still not be the optimal structure, but it will provide a much much more solid ground for all future work and comes with the most significant improvements this library has seen since I am involved in the project, thanks a lot Sina!!!

I've had a final look at all files, looks good.

Feel free to merge. 😄

no-1ne · 2019-05-27T15:47:24Z

Yay! can you also push the latest to npm pls

holgerd77 · 2019-05-27T17:09:15Z

@startupgurukul probably two days if nothing unexpected trigger a delay until a beta release on npm

holgerd77 · 2019-05-27T22:51:46Z

@s1na npm run testStatePetersburg is actually failing for me on master for all tests, even with a clean npm install + previously delete node_modules folder. Some example output:

$ npm run testStatePetersburg

> ethereumjs-vm@3.0.0 testStatePetersburg
> npm run build:dist && node ./tests/tester -s --fork='Petersburg' --dist

> ethereumjs-config-build

+ exec tsc -p ./tsconfig.prod.json
TAP version 13
# GeneralStateTests
# file: addNonConst test: addNonConst
not ok 1 the state roots should match
  ---
    operator: equal
    expected: |-
      '2d6da043f5cfd9fe3b1feab48970d855bf5570f5316492869642b228d8bed3ca'
    actual: |-
      '3c3f05727bc49ff870f5e780c5d00426d9c153de7e23443e70ec2da43d7f731c'
    at: replenish (/Users/hdrewes/Documents/DEV/EthereumJS/ethereumjs-vm/node_modules/async/dist/async.js:998:17)
  ...
not ok 2 the state roots should match
  ---
    operator: equal
    expected: |-
      'e396abd1e58496cc86a1a5bc31af70c98926cceef3738e1189af4c226b61da15'
    actual: |-
      '3c3f05727bc49ff870f5e780c5d00426d9c153de7e23443e70ec2da43d7f731c'
    at: replenish (/Users/hdrewes/Documents/DEV/EthereumJS/ethereumjs-vm/node_modules/async/dist/async.js:998:17)
  ...

Any idea?

s1na · 2019-05-28T08:37:07Z

@holgerd77 Hmm 🤔 I tried on a fresh clone and the tests seem to pass. I wonder what could be the cause. Could you maybe add an console.log(err) here:

https://github.com/ethereumjs/ethereumjs-vm/blob/9f96231cf7b4b185368092416aa7af2c30d2f90b/lib/runTx.ts#L95-L96

to see if any error is occuring?

holgerd77 · 2019-05-28T09:27:55Z

@s1na Ah yes, great hint:

+ exec tsc -p ./tsconfig.prod.json
TAP version 13
# GeneralStateTests
# file: addNonConst test: addNonConst
TypeError: bloom_1.default is not a constructor
    at txLogsBloom (/ethereumjs-vm/dist/runTx.js:250:17)
    at VM.<anonymous> (/ethereumjs-vm/dist/runTx.js:157:37)
    at step (/ethereumjs-vm/dist/runTx.js:32:23)
    at Object.next (/ethereumjs-vm/dist/runTx.js:13:53)
    at fulfilled (/ethereumjs-vm/dist/runTx.js:4:58)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)
not ok 1 the state roots should match
  ---
    operator: equal
    expected: |-
      '2d6da043f5cfd9fe3b1feab48970d855bf5570f5316492869642b228d8bed3ca'
    actual: |-
      '3c3f05727bc49ff870f5e780c5d00426d9c153de7e23443e70ec2da43d7f731c'
    at: replenish (/node_modules/async/dist/async.js:998:17)

s1na · 2019-05-28T09:35:42Z

Maybe the typescript compiler hasn't overwritten previously built files. Could you try removing dist and then running the tests?

holgerd77 · 2019-05-28T09:39:04Z

Ah, yes, works: 😄

s1na added 2 commits March 22, 2019 09:22

Bump version to 4

577e953

Upgrade babel to 7, use transform-runtime plugin

256fe59

s1na force-pushed the v4 branch from 3f8a3d8 to 256fe59 Compare March 22, 2019 08:23

s1na mentioned this pull request Mar 22, 2019

[v4] Add promisified wrapper for stateManager #480

Merged

s1na and others added 4 commits March 22, 2019 11:21

Add promisified wrapper for stateManager (#480)

3ab73a6

Merge branch 'master' into v4

ca5398a

Merge branch 'v4' of github.com:ethereumjs/ethereumjs-vm into v4

66153e5

Merge branch 'master' into v4

c5b25c6

s1na mentioned this pull request Mar 24, 2019

Class-based promisified rewrite of runCall and runCode #483

Merged

s1na mentioned this pull request Apr 1, 2019

Use EEI methods in opFns #486

Merged

holgerd77 mentioned this pull request Apr 5, 2019

Error Management Improvements / Add error codes #487

Open

s1na mentioned this pull request Apr 5, 2019

Promisify async opcode handlers #491

Merged

evm: promisify async opFns (#491)

ed5b1a9

holgerd77 reviewed Apr 8, 2019

View reviewed changes

lib/evm/interpreter.js Outdated Show resolved Hide resolved

holgerd77 reviewed Apr 8, 2019

View reviewed changes

lib/evm/interpreter.js Outdated Show resolved Hide resolved

holgerd77 reviewed Apr 8, 2019

View reviewed changes

s1na mentioned this pull request Apr 8, 2019

Detach precompiles from VM #492

Merged

Detach precompiles from VM (#492)

ac60927

* Detach list of precompiles from VM * evm: add getPrecompile method to interpreter

s1na mentioned this pull request Apr 9, 2019

Promisify runTx internals #493

Merged

Promisify runTx internals (#493)

519a076

* Promisify runTx internals * Fix linting error

s1na mentioned this pull request Apr 10, 2019

Rewrite runBlock internals with async/await #494

Merged

holgerd77 mentioned this pull request Apr 10, 2019

Monorepo clusters / Testing integration of connected libraries ethereumjs/organization#48

Closed

Rewrite runBlock internals with async/await (#494)

484a339

s1na mentioned this pull request Apr 11, 2019

Setup gradual process for migrating to Typescript #495

Merged

s1na mentioned this pull request Apr 15, 2019

Migrate state module to TS #496

Merged

Migrate state module to TS (#496)

b75d1da

* Mv lib/state/promisified.js to lib/state/promisified.ts * Change state file types to ts * Migrate state module to ts

s1na added 3 commits May 15, 2019 10:17

Migrate runCode to typescript (#508)

aa859a2

* Change runCode filetype to ts * Migrate runCode to ts

Migrate runCall to typescript (#510)

acd56bf

* Change runCall filetype to ts * Migrate runCall to ts

Migrate runTx to typescript (#511)

41e867e

* Change runTx filetype to ts * Migrate runTx to ts

s1na mentioned this pull request May 21, 2019

Migrate runBlock to typescript #512

Merged

s1na added 4 commits May 21, 2019 16:35

Migrate runBlock to typescript (#512)

c27019b

* Change runBlock filetype to ts * Migrate runBlock to ts

Drop runJit (#515)

d642354

Migrate runBlockchain to typescript (#517)

244b4ac

* Change runBlockchain filetype to ts * Migrate runBlockchain to ts

Use complete typescript configs, fix linting/formatting errors (#518)

c0fc752

* Use typescript configs * Fix tslint errors * Add prettier config * Fix formatting errors

holgerd77 mentioned this pull request May 25, 2019

Istanbul Hardfork Meta Issue #501

Closed

18 tasks

Fix merge conflicts

074c0b1

Fix linting errors

00f99c2

holgerd77 approved these changes May 27, 2019

View reviewed changes

s1na merged commit 7680b82 into master May 27, 2019

axic deleted the v4 branch June 20, 2019 11:50

evertonfraga added the package: vm label Feb 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V4 tracker #479

V4 tracker #479

s1na commented Mar 22, 2019 •

edited

Loading

coveralls commented Mar 22, 2019 •

edited

Loading

holgerd77 Apr 8, 2019

no-1ne commented May 14, 2019

holgerd77 commented May 14, 2019

holgerd77 commented May 25, 2019

s1na commented May 27, 2019

holgerd77 commented May 27, 2019

lgtm-com bot commented May 27, 2019

lgtm-com bot commented May 27, 2019

s1na commented May 27, 2019 •

edited

Loading

holgerd77 left a comment

no-1ne commented May 27, 2019 •

edited

Loading

holgerd77 commented May 27, 2019

holgerd77 commented May 27, 2019

s1na commented May 28, 2019

holgerd77 commented May 28, 2019

s1na commented May 28, 2019

holgerd77 commented May 28, 2019

V4 tracker #479

V4 tracker #479

Conversation

s1na commented Mar 22, 2019 • edited Loading

coveralls commented Mar 22, 2019 • edited Loading

holgerd77 Apr 8, 2019

Choose a reason for hiding this comment

no-1ne commented May 14, 2019

holgerd77 commented May 14, 2019

holgerd77 commented May 25, 2019

s1na commented May 27, 2019

holgerd77 commented May 27, 2019

lgtm-com bot commented May 27, 2019

lgtm-com bot commented May 27, 2019

s1na commented May 27, 2019 • edited Loading

holgerd77 left a comment

Choose a reason for hiding this comment

no-1ne commented May 27, 2019 • edited Loading

holgerd77 commented May 27, 2019

holgerd77 commented May 27, 2019

s1na commented May 28, 2019

holgerd77 commented May 28, 2019

s1na commented May 28, 2019

holgerd77 commented May 28, 2019

s1na commented Mar 22, 2019 •

edited

Loading

coveralls commented Mar 22, 2019 •

edited

Loading

s1na commented May 27, 2019 •

edited

Loading

no-1ne commented May 27, 2019 •

edited

Loading