camera_validator: Fix thread getting stuck (empty windows) #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the creation of the cv2.namedWindow from the MonoCameraValidator
constructor to the callback function. Otherwise, this caused the
following error:
QObject::startTimer: Timers cannot be started from another thread
... with the result that the image windows remained black and the node
became stuck.
Fixes ethz-asl#201 .
|
Can one of the admins verify this patch? |
sneheshs
approved these changes
Jan 27, 2020
|
Any updates on this please? |
|
This has been merged into PR #515. Let me know if any other issues. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the creation of the cv2.namedWindow from the MonoCameraValidator constructor to the callback function. Otherwise, this caused the following error:
... with the result that the image windows remained black and the node became stuck.
Other changes:
Fixes #201 .
This PR includes a cleaned-up version of #275 , so once this is merged, #275 can be closed.