Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with pybindings and tango interface #202

Closed
helenol opened this issue Aug 22, 2018 · 3 comments
Closed

Decide what to do with pybindings and tango interface #202

helenol opened this issue Aug 22, 2018 · 3 comments

Comments

@helenol
Copy link
Collaborator

helenol commented Aug 22, 2018

Since there's no longer a google tango, perhaps it doesn't make sense to keep them?
The python bindings can also move to their own package/repo, as we do not maintain them or test them, and they're anyway on the higher level interface (i.e., all they access is the internal ESDF layer anyway, no need for them to be in voxblox_ros).

@ZacharyTaylor @mfehr : thoughts?

@ZacharyTaylor
Copy link
Contributor

I had a browse through the forks of voxblox a while back and it seems like some people do use them. However, I agree that if we are not using / testing them we will eventually break them all. Not sure what the solution is

@mfehr
Copy link
Contributor

mfehr commented Aug 27, 2018

I think moving them to a separate package/repo makes sense, because without unit testing we will break them. Maybe it's worth trying to get in touch with some of the people using them, they might be willing to help/take over maintenance or even write some tests?

@helenol
Copy link
Collaborator Author

helenol commented Sep 19, 2018

@helenol helenol closed this as completed Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants