Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace current datasets in tutorials with internal datasets #202

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

ostreech1997
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

Closes #192.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ostreech1997 ostreech1997 added this to the Internal datasets milestone Dec 19, 2023
@ostreech1997 ostreech1997 added the datasets Work with datasets label Dec 19, 2023
Copy link

github-actions bot commented Dec 19, 2023

🚀 Deployed on https://deploy-preview-202--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 19, 2023 21:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 19, 2023 22:04 Inactive
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (dd1ace5) 88.93% compared to head (93e3e4f) 87.77%.
Report is 5 commits behind head on internal_datasets.

Files Patch % Lines
etna/analysis/forecast/plots.py 42.85% 20 Missing ⚠️
etna/datasets/internal_datasets.py 87.75% 6 Missing ⚠️
etna/datasets/tsdataset.py 92.15% 4 Missing ⚠️
etna/models/nn/deepar_native/loss.py 94.33% 3 Missing ⚠️
etna/models/base.py 66.66% 2 Missing ⚠️
etna/pipeline/hierarchical_pipeline.py 91.66% 2 Missing ⚠️
etna/metrics/intervals_metrics.py 98.24% 1 Missing ⚠️
etna/models/nn/deepar_native/deepar.py 99.19% 1 Missing ⚠️
etna/transforms/decomposition/deseasonal.py 83.33% 1 Missing ⚠️
etna/transforms/math/limit.py 97.82% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                  Coverage Diff                  @@
##           internal_datasets     #202      +/-   ##
=====================================================
- Coverage              88.93%   87.77%   -1.16%     
=====================================================
  Files                    205      199       -6     
  Lines                  13026    13181     +155     
=====================================================
- Hits                   11585    11570      -15     
- Misses                  1441     1611     +170     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request December 20, 2023 06:52 Inactive
Copy link

review-notebook-app bot commented Dec 20, 2023

View / edit / reply to this conversation on ReviewNB

d-a-bunin commented on 2023-12-20T08:15:03Z
----------------------------------------------------------------

May be we should add here that there is a dedicated documentation page where user could read about each dataset.


@github-actions github-actions bot temporarily deployed to pull request December 20, 2023 11:45 Inactive
@ostreech1997 ostreech1997 merged commit b07bcce into internal_datasets Dec 20, 2023
16 checks passed
@ostreech1997 ostreech1997 deleted the issue-192 branch December 20, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Work with datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants