Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit error for local ftp path compatibility between 0.1.3 and 0.1.4 #34

Merged
merged 4 commits into from
Jul 1, 2020
Merged

Explicit error for local ftp path compatibility between 0.1.3 and 0.1.4 #34

merged 4 commits into from
Jul 1, 2020

Conversation

gmaze
Copy link
Member

@gmaze gmaze commented Jun 30, 2020

No description provided.

@gmaze gmaze linked an issue Jun 30, 2020 that may be closed by this pull request
Problem accessing data with src ='localftp' in 0.1.4 #33
Closed
@gmaze gmaze changed the title Warning for local ftp path compatibility between 0.1.3 and 0.1.4 Explicit error for local ftp path compatibility between 0.1.3 and 0.1.4 Jun 30, 2020
@gmaze gmaze requested a review from quai20 June 30, 2020 16:30
@gmaze
Copy link
Member Author

gmaze commented Jun 30, 2020

This PR implements a path checker for the data and index local ftp fetchers.

An error is raised if the option local_ftp does not point toward a path with a sub-folder named dac and at least one sub-sub-folder named according to one the GDAC ftp DAC names.

If dac is not found but at least one sub-folder is named according to one the GDAC ftp DAC names, then the error message is more explicit and points toward the need of a dac folder.

This accounts for the fetchers change between 0.1.3 and 0.1.4.

quai20
quai20 approved these changes Jul 1, 2020
View reviewed changes
argopy/errors.py Outdated Show resolved Hide resolved
gmaze and others added 2 commits July 1, 2020 09:45
@gmaze @quai20
Update argopy/errors.py
f907388 
Co-authored-by: Kevin Balem <quai20@users.noreply.github.com>
@gmaze
Implement API check
fdecbff
@gmaze gmaze requested a review from quai20 July 1, 2020 09:06
@gmaze gmaze merged commit 5a46a39 into master Jul 1, 2020
This was referenced Jul 1, 2020
Closed
Closed
@gmaze gmaze deleted the localftppath branch July 1, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quai20 quai20 quai20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem accessing data with src ='localftp' in 0.1.4
2 participants
@gmaze @quai20