-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rpc): handle case when node is not persisting abci responses #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1863 +/- ##
==========================================
- Coverage 70.53% 70.52% -0.02%
==========================================
Files 315 315
Lines 23404 23412 +8
==========================================
+ Hits 16509 16511 +2
- Misses 6079 6084 +5
- Partials 816 817 +1
|
GAtom22
requested review from
facs95 and
0xstepit
and removed request for
a team
October 13, 2023 21:35
fedekunze
approved these changes
Oct 13, 2023
https://github.com/Mergifyio backport release/v15.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
(cherry picked from commit d06c4c8) # Conflicts: # CHANGELOG.md
GAtom22
added a commit
that referenced
this pull request
Oct 16, 2023
…kport #1863) (#1868) * fix(rpc): handle case when node is not persisting abci responses (#1863) (cherry picked from commit d06c4c8) # Conflicts: # CHANGELOG.md * fix conflicts * (test) fix port to avoid collision --------- Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: tom <tomasguerraalda@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When setting the configuration parameter
discard_abci_responses = true
, all JSON-RPC methods that rely onTendermintBlockResult
(e.g.:eth_gasPrice
,eth_getBlockByNumber
,eth_getBlockByHash
,eth_getTransactionByHash
,eth_getTransactionReceipt
,eth_getTransactionLogs
,eth_feeHistory
) will not return the expected result (usuallynull
) and in some cases cause a panic.For example, in
eth_gasPrice
the error logs are:This PR adds the corresponding changes to handle this gracefully and avoid the panic.
As a result, the user will get the following response:
Closes #XXX