Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): handle case when node is not persisting abci responses (backport #1863) #1868

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2023

This is an automatic backport of pull request #1863 done by Mergify.
Cherry-pick of d06c4c8 has failed:

On branch mergify/bp/release/v15.0.x/pr-1863
Your branch is up to date with 'origin/release/v15.0.x'.

You are currently cherry-picking commit d06c4c87.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   rpc/backend/backend.go
	modified:   rpc/backend/blocks.go
	modified:   rpc/backend/call_tx.go
	modified:   rpc/backend/chain_info.go
	modified:   rpc/backend/utils.go
	modified:   rpc/namespaces/ethereum/eth/api.go
	new file:   tests/nix_tests/configs/discard-abci-resp.jsonnet
	new file:   tests/nix_tests/test_no_abci_resp.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit d06c4c8)

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #1868 (c2c3e28) into release/v15.0.x (848d850) will decrease coverage by 0.02%.
Report is 4 commits behind head on release/v15.0.x.
The diff coverage is 60.00%.

❗ Current head c2c3e28 differs from pull request most recent head ed4a447. Consider uploading reports for the commit ed4a447 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v15.0.x    #1868      +/-   ##
===================================================
- Coverage            70.45%   70.43%   -0.02%     
===================================================
  Files                  314      314              
  Lines                23347    23355       +8     
===================================================
+ Hits                 16449    16451       +2     
- Misses                6073     6078       +5     
- Partials               825      826       +1     
Files Coverage Δ
rpc/backend/backend.go 76.47% <ø> (ø)
rpc/backend/blocks.go 84.92% <100.00%> (ø)
rpc/backend/chain_info.go 81.28% <100.00%> (-0.11%) ⬇️
rpc/backend/call_tx.go 59.41% <57.14%> (-0.33%) ⬇️
rpc/backend/utils.go 43.09% <40.00%> (-0.41%) ⬇️

@GAtom22 GAtom22 enabled auto-merge (squash) October 16, 2023 14:32
@GAtom22 GAtom22 merged commit 045790e into release/v15.0.x Oct 16, 2023
17 checks passed
@GAtom22 GAtom22 deleted the mergify/bp/release/v15.0.x/pr-1863 branch October 16, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant