Skip to content
This repository has been archived by the owner on Apr 11, 2023. It is now read-only.

Rewrite genome paths #7

Closed
10 tasks done
ewels opened this issue Jul 11, 2014 · 3 comments
Closed
10 tasks done

Rewrite genome paths #7

ewels opened this issue Jul 11, 2014 · 3 comments
Assignees
Milestone

Comments

@ewels
Copy link
Owner

ewels commented Jul 11, 2014

Currently, genome paths are handled in a very inflexible way. Basically, a genome / bowtie / bowtie2 / gtf path has to be specified and each is dealt with manually. This is bad as it's difficult if not impossible to add other types of genome indices (bismark / other aligners) and involves quite a bit of code duplication.

  • Allow any @reference tag in the genomes.config file
  • Parse these into a single hash so we don't care what the tag was
  • Allow pipelines and modules to use the @require_reference <type> tag for anything that's in the hash
  • Update pipelines and modules to use this syntax
  • Alter modules to check for and include paths in a consistent manner

With this, the current listing and genomes wizard will have to be updated:

  • Listing can be much less verbose and more agnostic to tag name
  • Wizard should still start by asking for assembly / genome id but then allow any tag
  • Wizard should start by iterating through a directory and checking for known indices: .fa, .ebwt, .bt2 files, .gtf files and any other known structure
  • This will make wizard way faster and more accurate.
  • Confirm each detected path so that we can ignore bogus ones.
@ewels ewels added this to the Version 0.4 milestone Jul 11, 2014
@ewels ewels self-assigned this Jul 11, 2014
ewels added a commit that referenced this issue Aug 7, 2014
@ewels ewels mentioned this issue Sep 26, 2014
@ewels
Copy link
Owner Author

ewels commented Jan 20, 2015

Quite a lot of commits for this issue:

@ewels
Copy link
Owner Author

ewels commented Jan 20, 2015

Written and tested (a bit). Seems to be working nicely. New --add_genome wizard is much much nicer..

@ewels ewels closed this as completed Jan 20, 2015
@ewels
Copy link
Owner Author

ewels commented Jan 20, 2015

I should mention - @stu2, @s-andrews, @FelixKrueger and anyone else who might be using the development fork of Cluster Flow - this update will break your setup (old style reference genomes won't be recognised).

See the readme for instructions on updating. It's a 2 minute job, so shouldn't be a big deal..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant