Updated docker build #1964
Merged
Updated docker build #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Docker build configuration to align with the latest .NET runtime dependencies as referenced from the official dotnet-docker repository. The changes modernize package versions and improve Docker layer caching efficiency.
- Updated .NET runtime dependency package versions to newer Ubuntu Noble versions
- Reorganized RUN commands for better Docker layer caching
- Added cleanup of apt cache to reduce image size
Comment on lines
+114
to
+130
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| supervisor \ | ||
| wget \ | ||
| dos2unix \ | ||
| ca-certificates \ | ||
| \ | ||
| # .NET dependencies | ||
| libc6 \ | ||
| libgcc1 \ | ||
| libgssapi-krb5-2 \ | ||
| libicu66 \ | ||
| libssl1.1 \ | ||
| libgcc-s1 \ | ||
| libicu74 \ | ||
| libssl3t64 \ | ||
| libstdc++6 \ | ||
| zlib1g && \ | ||
| dos2unix /app/docker-entrypoint.sh | ||
| tzdata \ | ||
| tzdata-legacy \ | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && dos2unix /app/docker-entrypoint.sh |
There was a problem hiding this comment.
The same RUN command block appears twice in the Dockerfile (lines 114-130 and 175-191). Consider extracting this into a reusable pattern or consolidating the stages if possible to reduce duplication and maintenance overhead.
Copilot uses AI. Check for mistakes.
|
ejsmith
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/dotnet/dotnet-docker/blob/main/src/runtime-deps/10.0/noble/amd64/Dockerfile