Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triangle: incorrect test in some tracks #106

Closed
kytrinyx opened this issue Jan 29, 2016 · 3 comments
Closed

triangle: incorrect test in some tracks #106

kytrinyx opened this issue Jan 29, 2016 · 3 comments

Comments

@kytrinyx
Copy link
Member

Please check if there's a test that states that a triangle with sides 2, 4, 2 is invalid. The triangle inequality states that for any triangle, the sum of the lengths of any two sides must be greater than or equal to the length of the remaining side. If this doesn't affect this track, go ahead and just close the issue.

@robphoenix
Copy link

There is this test:

  test "triangles violating triangle inequality are illegal 2" do
    assert Triangle.kind(2, 4, 2) == { :error, "side lengths violate triangle inequality" }
  end

@kytrinyx
Copy link
Member Author

kytrinyx commented Feb 1, 2016

OK, cool. Let's wait until the discussion here settles: exercism/erlang#85 - then decide whether to remove it or change it.

@kytrinyx
Copy link
Member Author

There was a bit of confusion with this issue. I've summarized my current understanding here: exercism/problem-specifications#202

I am closing this issue. If necessary I will open a new issue once we have come to an agreement about how to resolve the inconsistencies and what exact steps to take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants