Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[custom-set] example and test suite diverge #198

Closed
NobbZ opened this issue Jun 18, 2016 · 0 comments · Fixed by #226
Closed

[custom-set] example and test suite diverge #198

NobbZ opened this issue Jun 18, 2016 · 0 comments · Fixed by #226

Comments

@NobbZ
Copy link
Member

NobbZ commented Jun 18, 2016

The tests do check for Inspect as foolows:

  test "inspect" do
    assert inspect(CustomSet.new) == "%CustomSet{list: []}"
    assert inspect(CustomSet.new([1,3,2])) == "%CustomSet{list: [1, 2, 3]}"
    assert inspect(CustomSet.new(["A",:b,?C])) == "%CustomSet{list: [67, :b, \"A\"]}"
  end

While the example implementation does implement Inspect as follows:

  def inspect(s, opts) do
    concat ["#<CustomSet ", to_doc(CustomSet.to_list(s), opts), ">"]
  end

Before commit 9222be9 the example and the test matched.

devonestes added a commit to devonestes/xelixir that referenced this issue Aug 20, 2016
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 20, 2016
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 20, 2016
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 21, 2016
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 21, 2016
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
parkerl pushed a commit that referenced this issue Aug 22, 2016
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues #121, #180, #189, #198 and #217.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant