Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tests for the Custom Set problem #189

Closed
ryanplusplus opened this issue Jun 2, 2016 · 0 comments · Fixed by #226
Closed

Updated tests for the Custom Set problem #189

ryanplusplus opened this issue Jun 2, 2016 · 0 comments · Fixed by #226
Labels
good first issue 🐥

Comments

@ryanplusplus
Copy link
Member

In order to reduce the amount of code required to pass incremental tests (assuming that users pass tests starting from the top), the order of the tests was modified slightly.

Since this track implements Custom Set, please take a look at the new custom-set.json file and see if your track should update its tests.

If you do need to update your tests, please refer to this issue in your PR. That helps us see which tracks still need to update their tests.

If your track is already up to date, go ahead and close this issue.

More details on this change are available in exercism/problem-specifications#257.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 20, 2016
@devonestes
Rewrite tests and example for CustomSet
5ae0eb0 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
@devonestes devonestes mentioned this issue Aug 20, 2016
Merged
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 20, 2016
@devonestes
Rewrite tests and example for CustomSet
eb6bf94 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 20, 2016
@devonestes
Rewrite tests and example for CustomSet
1539db4 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 21, 2016
@devonestes
Rewrite tests and example for CustomSet
dfbe2ae 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 21, 2016
@devonestes
Rewrite tests and example for CustomSet
b81dbdd 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
parkerl pushed a commit that referenced this issue Aug 22, 2016
@devonestes @parkerl
Rewrite tests and example for CustomSet (#226)
faf6f19 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues #121, #180, #189, #198 and #217.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 🐥
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite tests and example for CustomSet devonestes/xelixir
2 participants
@kytrinyx @ryanplusplus