Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The custom-set exercism is based around the deprecated Set module and removed Set behaviour #217

Closed
lpil opened this issue Aug 8, 2016 · 2 comments · Fixed by #226
Closed

The custom-set exercism is based around the deprecated Set module and removed Set behaviour #217

lpil opened this issue Aug 8, 2016 · 2 comments · Fixed by #226

Comments

@lpil
Copy link
Sponsor Member

lpil commented Aug 8, 2016 •
edited
Loading

Hello!

The Set module was deprecated in 1.2, and the behaviour has since been removed. It's not possible to directly port the changes to the MapSet replacement as it's a single data structure implementation rather than a behaviour with a default implementation.

This exercise needs to be removed, or entirely re-written. :(

I notice there are other open issues for this exercise. #198 #180 #121
@devonestes
Copy link
Contributor

Yeah, at this point we just need to totally re-write the test suite for that exercise, so that's going to happen eventually. I'm confident that we can keep the exercise as it is, though, and just replace the test suite.

@lpil
Copy link
Sponsor Member Author

lpil commented Aug 8, 2016 •
edited
Loading

When we do so it would be good to add a note saying that in the real world we should use MapSet instead of inventing our own set :)

devonestes added a commit to devonestes/xelixir that referenced this issue Aug 20, 2016
@devonestes
Rewrite tests and example for CustomSet
5ae0eb0 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
@devonestes devonestes mentioned this issue Aug 20, 2016
Merged
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 20, 2016
@devonestes
Rewrite tests and example for CustomSet
eb6bf94 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 20, 2016
@devonestes
Rewrite tests and example for CustomSet
1539db4 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 21, 2016
@devonestes
Rewrite tests and example for CustomSet
dfbe2ae 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes added a commit to devonestes/xelixir that referenced this issue Aug 21, 2016
@devonestes
Rewrite tests and example for CustomSet
b81dbdd 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
parkerl pushed a commit that referenced this issue Aug 22, 2016
@devonestes @parkerl
Rewrite tests and example for CustomSet (#226)
faf6f19 
We have a lot of issues open around the `CustomSet` example. This PR rewrites
that to remove the deprecated `Set` module, and also updates it to use the
current tests listed in the `exercism/x-common` repo.

This should address Issues #121, #180, #189, #198 and #217.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite tests and example for CustomSet devonestes/xelixir
2 participants
@lpil @devonestes