Rewrite tests and example for CustomSet #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devonestes
force-pushed
the
rewrite-custom-set
branch
2 times, most recently
from
eb6bf94
to
1539db4
Compare
|
@devonestes excellent work as usual! I think I have a couple small comments. This diff is a little challenging to review. I'm mostly looking at it as a new exercise. |
| test "sets with elements are not empty" do | ||
| custom_set = CustomSet.new([1]) | ||
| assert CustomSet.empty?(custom_set) == false | ||
| end | ||
| end | ||
|
|
||
| @tag :pending |
There was a problem hiding this comment.
I like the describe blocks. Are you at all worried that @pending these blocks will make too many test go red at one time? It seems ok since each is focused on one function.
There was a problem hiding this comment.
Frankly, I didn't really think about it too much since that was a refactor. But now that you mention it, I don't think it's a problem. When I was doing the implementation for these, the examples in the tests pretty much all went green at the same time since there aren't really many edge cases to handle in these operations.
devonestes
force-pushed
the
rewrite-custom-set
branch
from
1539db4
to
dfbe2ae
Compare
We have a lot of issues open around the `CustomSet` example. This PR rewrites that to remove the deprecated `Set` module, and also updates it to use the current tests listed in the `exercism/x-common` repo. This should address Issues exercism#121, exercism#180, exercism#189, exercism#198 and exercism#217.
devonestes
force-pushed
the
rewrite-custom-set
branch
from
dfbe2ae
to
b81dbdd
Compare
devonestes
added a commit
to devonestes/xelixir
that referenced
this pull request
Aug 21, 2016
When we ran `mix test` we were getting several compiler warnings. Here's the ouput that we got before this PR: ``` warning: behaviour Set undefined exercises/custom-set/example.exs:1 warning: the Inspect protocol has already been consolidated, an implementation for CustomSet has no effect exercises/custom-set/example.exs:126 warning: function digits/1 is private, @doc's are always discarded for private functions exercises/largest-series-product/example.exs:3 warning: function slices/2 is private, @doc's are always discarded for private functions exercises/largest-series-product/example.exs:17 warning: redefining module DNA (current version defined in memory) exercises/nucleotide-count/example.exs:1 warning: redefining module DNA (current version defined in memory) exercises/rna-transcription/example.exs:1 Including tags: [:pending] warning: redefining module ChangeTest (current version defined in memory) exercises/flatten-array/flatten_array_test.exs:8 warning: redefining module ChangeTest (current version defined in memory) exercises/hexadecimal/hexadecimal_test.exs:8 warning: redefining module DNATest (current version defined in memory) exercises/nucleotide-count/nucleotide_count_test.exs:8 warning: redefining module DNATest (current version defined in memory) exercises/rna-transcription/rna_transcription_test.exs:8 warning: the Inspect protocol has already been consolidated, an implementation for BinTree has no effect exercises/zipper/zipper_test.exs:16 ``` I addressed all of the warnings except those for `CustomSet` since those warnings are taken care of in exercism#226. Many of them were naming issues for modules, and funny enough this fix of the compiler warnings pointed out that we had a typo in a test that should have failed but wasn't failing! I've also fixed that typo.
parkerl
pushed a commit
that referenced
this pull request
Aug 21, 2016
When we ran `mix test` we were getting several compiler warnings. Here's the ouput that we got before this PR: ``` warning: behaviour Set undefined exercises/custom-set/example.exs:1 warning: the Inspect protocol has already been consolidated, an implementation for CustomSet has no effect exercises/custom-set/example.exs:126 warning: function digits/1 is private, @doc's are always discarded for private functions exercises/largest-series-product/example.exs:3 warning: function slices/2 is private, @doc's are always discarded for private functions exercises/largest-series-product/example.exs:17 warning: redefining module DNA (current version defined in memory) exercises/nucleotide-count/example.exs:1 warning: redefining module DNA (current version defined in memory) exercises/rna-transcription/example.exs:1 Including tags: [:pending] warning: redefining module ChangeTest (current version defined in memory) exercises/flatten-array/flatten_array_test.exs:8 warning: redefining module ChangeTest (current version defined in memory) exercises/hexadecimal/hexadecimal_test.exs:8 warning: redefining module DNATest (current version defined in memory) exercises/nucleotide-count/nucleotide_count_test.exs:8 warning: redefining module DNATest (current version defined in memory) exercises/rna-transcription/rna_transcription_test.exs:8 warning: the Inspect protocol has already been consolidated, an implementation for BinTree has no effect exercises/zipper/zipper_test.exs:16 ``` I addressed all of the warnings except those for `CustomSet` since those warnings are taken care of in #226. Many of them were naming issues for modules, and funny enough this fix of the compiler warnings pointed out that we had a typo in a test that should have failed but wasn't failing! I've also fixed that typo.
|
Looks great! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of issues open around the
CustomSetexample. This PR rewritesthat to remove the deprecated
Setmodule, and also updates it to use thecurrent tests listed in the
exercism/x-commonrepo.resolves #121
resolves #180
resolves #189
resolves #198
resolves #217