Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rna-transcription to match README #3

Closed
kytrinyx opened this issue Feb 28, 2014 · 4 comments
Closed

Update rna-transcription to match README #3

kytrinyx opened this issue Feb 28, 2014 · 4 comments

Comments

@kytrinyx
Copy link
Member

See exercism/exercism#1310 for original discussion.

@magthe
Copy link
Contributor

magthe commented Oct 15, 2014

I'm guessing this comment belongs in this issue.

Currently rna-transcription requires more work than I expected:

  • there are no instructions on how to run the exercise, I assumed I could reuse the instructions from the first exercise (leap), but
  • the naming of files is important, the tests expect a module named dna, but since the tests are named rna_transcription_tests the Erlang system expects them to be a test for a module named rna_transcription, so
  • the test file either has to be renamed to dna_tests.erl and its module renamed to dna_tests, or every test has to be changed to look for the function-under-test in a module called rna_transcription.

@kytrinyx
Copy link
Member Author

I think it is fine to rename the expected module and the files to match the exact name of the problem. In the early days there were some really hacky reasons why this was done in this way, and it really makes no sense any more.

@magthe
Copy link
Contributor

magthe commented Oct 16, 2014

I created a pull request for this in xerlang, #27, hopefully it's good enough.

@tmcgilchrist
Copy link
Contributor

Seems like this has been fixed @kytrinyx please re-open if I'm mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants