Fix issues of naming in rna-transcription. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| % erl -noshell -eval "eunit:test(rna_transcription, [verbose])" -s init stop | ||
|
|
||
| -module(rna_transcription_tests). | ||
| -include(rna_transcription, [to_rna/1]). |
There was a problem hiding this comment.
This line is redundant. All of the calls are fully qualified calls to the module, this statement imports the name from that module locally.
|
Other than that one line, this looks great. |
|
I'll try a |
The following changes all make it easier to run the tests: - Rename the test sources to match what eunit wants: tests for `foo` live in `foo_tests` (note the 's' at the end there). - Expect the module-under-test to be named `rna_transcription`. - Modify the test source to explicitly import the solution expected from the user. - Add instructions for compilation and running. All of this follows the lead of the previous exercise, `leap`. Signed-off-by: Magnus Therning <magnus@therning.org>
magthe
force-pushed
the
devo-rna-transciption
branch
from
095534f
to
8df71b7
Compare
|
Pushed a new version, now without the |
etrepum
added a commit
that referenced
this pull request
Oct 19, 2014
Fix issues of naming in rna-transcription.
lehoff
pushed a commit
to lehoff/xerlang
that referenced
this pull request
Dec 17, 2014
Fix issues of naming in rna-transcription.
yurrriq
added a commit
to lfex/xlfe
that referenced
this pull request
Aug 24, 2016
Update lfe-compile, lfe and ltest dependencies to close exercism#25. Move ltest dependency to the test profile and add {eunit_compile_opts, [{src_dirs, ["src", "test"]}]} to ensure the tests are compiled and fix exercism#27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes all make it easier to run the tests:
foolive infoo_tests(note the 's' at the end there).rna_transcription.All of this follows the lead of the previous exercise,
leap.Signed-off-by: Magnus Therning magnus@therning.org