Skip to content

Conversation

aldotele
Copy link
Contributor

This PR addresses karl's languages task on issue #2356


Reviewer Resources:

Track Policies

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a bunch of comments this time. Most of them are suggestions on the naming of the tests, as I believe they can be a bit shorter and clearer.

The others are about the test cases themselves, I believe we can make them a bit better.

@aldotele
Copy link
Contributor Author

Just commited the enhancements, thank you for the review!

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sanderploegsma sanderploegsma added the x:size/small Small amount of work label Sep 27, 2023
@sanderploegsma sanderploegsma merged commit 2c87b03 into exercism:main Sep 27, 2023
@aldotele aldotele deleted the test-runner-v3-karls-languages branch September 27, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants