-
-
Notifications
You must be signed in to change notification settings - Fork 721
Update karl's languages to use test runner v3 features #2493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update karl's languages to use test runner v3 features #2493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a bunch of comments this time. Most of them are suggestions on the naming of the tests, as I believe they can be a bit shorter and clearer.
The others are about the test cases themselves, I believe we can make them a bit better.
exercises/concept/karls-languages/src/test/java/LanguageListTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/karls-languages/src/test/java/LanguageListTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/karls-languages/src/test/java/LanguageListTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/karls-languages/src/test/java/LanguageListTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/karls-languages/src/test/java/LanguageListTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/karls-languages/src/test/java/LanguageListTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/karls-languages/src/test/java/LanguageListTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/karls-languages/src/test/java/LanguageListTest.java
Outdated
Show resolved
Hide resolved
exercises/concept/karls-languages/src/test/java/LanguageListTest.java
Outdated
Show resolved
Hide resolved
Just commited the enhancements, thank you for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This PR addresses karl's languages task on issue #2356
Reviewer Resources:
Track Policies