Skip to content

Conversation

bibekparajuli123
Copy link
Contributor

@bibekparajuli123 bibekparajuli123 commented Sep 6, 2025

pull request

This PR adds 'DisplayName' annotations to the test methods for the following practice exercises:
pov
prime-factors
protein-translation
proverb
pythagorean-triplet
queen-attack
rail-fence-cipher
raindrops
rational-numbers
react

Descriptions were taken from the corresponding canonical-data.json files in the problem-specifications repo.

Reviewer Resources:

Track Policies

Copy link
Contributor

github-actions bot commented Sep 6, 2025

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Comment on lines 125 to 126
@DisplayName("cannot attack if falling diagonals are only the same " +
"when reflected across the longest falling diagonal")
Copy link
Member

@jagdish-15 jagdish-15 Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@DisplayName("cannot attack if falling diagonals are only the same " +
"when reflected across the longest falling diagonal")
@DisplayName(
"cannot attack if falling diagonals are only the same " +
"when reflected across the longest falling diagonal"
)

Just this small change to keep it consistent with the earlier files!

@jagdish-15 jagdish-15 merged commit dfba4ad into exercism:main Sep 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants