-
-
Notifications
You must be signed in to change notification settings - Fork 645
Description
Getting Started
Here you can read about what Concept Exercises are and how they are structured:
If you have not done so yet, it is probably also helpful to do a couple of "Learning Exercises" (this is how they are called on the site) yourself. You can also look at the code of an existing concept exercise like bird-watcher
(concept for-loops
) for reference.
Main Task
Currently, the exercise factory-sensors
is only associated with the concept errors
. The exercise also requires the student to use code related to the concept inheritance
so the exercise should also introduce inheritance
properly. The task is to add this additional concept.
Things the new concept should cover:
- when is inheritance useful
extends
super
- overriding methods
Possible resources that might help:
- https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Objects/Inheritance
- https://javascript.info/class-inheritance
The exercise could probably stay as is but if you have a good idea how to improve it so it incorporates the new content even better, feel free to do changes.
Don't forget to adjust the design.md file to incorporate the new content and to add the new concept in the global config.json file.
Make sure the introduction.md of the exercise includes both concepts and check that the existing errors
concept does not duplicate the information in the new inheritance
concept.
Bonus Tasks
- Proof-read the existing concept docs, exercise docs etc.
- Note down potential analyzer comments in the design.md file, see design.md in Amusement Park for an example
How to proceed
- First accept this issue by saying "I'd like to work on this" (no need to wait for a response, just go ahead).
- Use this issue to discuss any questions you have, what should be included in the content and what not and to collect reference material.
- Create a PR and set "exercism/javascript" as reviewers. Additionally you can write in #maintaining-javascript on Slack that your PR is ready for review. Once you incorporated any critical feedback that the reviewer might give you and the PR is approved, it will be merged by a maintainer.