Skip to content

Update tests protein translation #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jagdish-15
Copy link
Contributor

Pull Request

This PR syncs tests.toml with the problem-specifications repository and updates the test file.

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@github-actions github-actions bot closed this Jun 25, 2025
@jagdish-15
Copy link
Contributor Author

BTW do we need the test names to be exactly the same as the descriptions in the prob-spec repo?
Currently, the single-codon tests get named something like this by the test file having loops:

Single codons
  √ Methionine RNA sequence 1 translates into Methionine (1 ms)
  √ Phenylalanine RNA sequence 1 translates into Phenylalanine (1 ms)
  √ Phenylalanine RNA sequence 2 translates into Phenylalanine
  √ Leucine RNA sequence 1 translates into Leucine
  √ Leucine RNA sequence 2 translates into Leucine (1 ms)
  √ Serine RNA sequence 1 translates into Serine
  √ Serine RNA sequence 2 translates into Serine (1 ms)
  √ Serine RNA sequence 3 translates into Serine (1 ms)
  √ Serine RNA sequence 4 translates into Serine (1 ms)
  √ Tyrosine RNA sequence 1 translates into Tyrosine
  √ Tyrosine RNA sequence 2 translates into Tyrosine
  √ Cysteine RNA sequence 1 translates into Cysteine (1 ms)
  √ Cysteine RNA sequence 2 translates into Cysteine
  √ Tryptophan RNA sequence 1 translates into Tryptophan
  √ STOP codon RNA sequence 1 (1 ms)
  √ STOP codon RNA sequence 2
  √ STOP codon RNA sequence 3

But to align with prob-spec repo, they should be:

Single codons
  √ Methionine RNA sequence
  √ Phenylalanine RNA sequence 1
  √ Phenylalanine RNA sequence 2
  √ Leucine RNA sequence 1
  √ Leucine RNA sequence 2
  √ Serine RNA sequence 1
  √ Serine RNA sequence 2
  √ Serine RNA sequence 3
  √ Serine RNA sequence 4
  √ Tyrosine RNA sequence 1
  √ Tyrosine RNA sequence 2
  √ Cysteine RNA sequence 1
  √ Cysteine RNA sequence 2
  √ Tryptophan RNA sequence
  √ STOP codon RNA sequence 1
  √ STOP codon RNA sequence 2
  √ STOP codon RNA sequence 3

@Cool-Katt Cool-Katt reopened this Jun 25, 2025
@Cool-Katt
Copy link
Contributor

Ideally, the tests should follow whatever is written in the problem-spec, unless it's a custom test that's not included with the spec but is specific to the track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants