Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exercise: rotational-cipher #44

Merged
merged 6 commits into from
Mar 8, 2017
Merged

Add exercise: rotational-cipher #44

merged 6 commits into from
Mar 8, 2017

Conversation

SaschaMann
Copy link
Contributor

No description provided.

@SaschaMann SaschaMann self-assigned this Feb 15, 2017
@SaschaMann SaschaMann changed the title WIP: I will implement exercise rotational-cipher RFC: Add exercise: rotational-cipher Feb 15, 2017
@SaschaMann SaschaMann changed the title RFC: Add exercise: rotational-cipher Add exercise: rotational-cipher Feb 15, 2017
@SaschaMann
Copy link
Contributor Author

SaschaMann commented Feb 15, 2017

Should be squashed on merge to remove the empty & config commit


# Bonus A
# @testset "string literal R13" begin
# @test R13"The quick brown fox jumps over the lazy dog." == "Gur dhvpx oebja sbk whzcf bire gur ynml qbt."
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use @test_skip as it is used in other language's test sets, just to conform common style (may it be?).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, just saw the issue regarding @test_skip and Travis.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try it but it threw an Error anyway on my end, so I thought Travis will fail the build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it throws a LoadError and fails the build.

Copy link
Contributor

@andrej-makarov-skrt andrej-makarov-skrt Feb 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@test_skip behavior is a bit confusing, there must be discussion or we should make another macro for test skipping special for exercism case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I'll leave this PR open until we have a solution to #45

Copy link
Contributor

@andrej-makarov-skrt andrej-makarov-skrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I liked this bonus task! :)

@SaschaMann
Copy link
Contributor Author

I will merge this now with the commented out tests and will revisit it in v0.6 once @test_skip behaves properly. Would be good to get some user feedback on how they'd like optional tests to be handled, too.

@SaschaMann SaschaMann merged commit 78ee9ab into exercism:master Mar 8, 2017
@SaschaMann SaschaMann deleted the smann/exercises/rotational-cipher branch March 8, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants