-
-
Notifications
You must be signed in to change notification settings - Fork 203
Update basics/about.md
#708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For @SleeplessByte. I can't assign the reviewer (as a non-maintainer here). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits
Functions can have parameters with default values. | ||
These values will be used if they are omitted where the function is invoked: | ||
|
||
```kotlin | ||
fun run() {} | ||
fun ping(host: String = "localhost") { | ||
println("PING --> $host") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In JS this is part of functions concept. I don't mind having it here, but if there will be separate concept, should move there. You can embed a link to a concept. Let me know if you don't know how to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't include this at first, for the exact reasons you give (there will be a Functions concept, though I've not written anything yet).
Unfortunately, the optional argument thing is baked into the current version of Lasagna. We could rewrite that, but it may be a backwards step for something already merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave it for now, we build the syllabus, and then we do a second (quick) run together making changes like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect it won't be the only thing we change later. A syllabus may need iterations!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha exactly. In JS (and TS later) we have many iterations.
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Added a few extra lines.
removed double "for"
@colinleach good to merge? |
It's as good as I can get it, for now... |
A small first PR, just touching one file.
In the merged version of this concept, the
introduction.md
is longer and more detailed than theabout.md
. The opposite should be true!This is a new
about.md
, based on the Introduction but expanded a little.