Skip to content

Conversation

colinleach
Copy link
Contributor

A small first PR, just touching one file.

In the merged version of this concept, the introduction.md is longer and more detailed than the about.md. The opposite should be true!

This is a new about.md, based on the Introduction but expanded a little.

@colinleach
Copy link
Contributor Author

For @SleeplessByte. I can't assign the reviewer (as a non-maintainer here).

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits

Comment on lines +74 to +80
Functions can have parameters with default values.
These values will be used if they are omitted where the function is invoked:

```kotlin
fun run() {}
fun ping(host: String = "localhost") {
println("PING --> $host")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In JS this is part of functions concept. I don't mind having it here, but if there will be separate concept, should move there. You can embed a link to a concept. Let me know if you don't know how to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't include this at first, for the exact reasons you give (there will be a Functions concept, though I've not written anything yet).

Unfortunately, the optional argument thing is baked into the current version of Lasagna. We could rewrite that, but it may be a backwards step for something already merged?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it for now, we build the syllabus, and then we do a second (quick) run together making changes like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it won't be the only thing we change later. A syllabus may need iterations!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha exactly. In JS (and TS later) we have many iterations.

colinleach and others added 5 commits August 29, 2025 14:26
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
Co-authored-by: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
@SleeplessByte
Copy link
Member

@colinleach good to merge?

@colinleach
Copy link
Contributor Author

It's as good as I can get it, for now...

@SleeplessByte SleeplessByte merged commit f7dba1a into exercism:main Aug 29, 2025
2 checks passed
@colinleach colinleach deleted the update-basics branch August 29, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants