Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordination: Prepare for students code using PHP 8.3 #155

Open
mk-mxp opened this issue Mar 5, 2024 · 3 comments
Open

Coordination: Prepare for students code using PHP 8.3 #155

mk-mxp opened this issue Mar 5, 2024 · 3 comments

Comments

@mk-mxp
Copy link

mk-mxp commented Mar 5, 2024

For exercism/php#652 we need to have the representer ready to accept PHP 8.3 code from students. The representer itself may run on a different PHP version.

@homersimpsons Can you outline the required work to do here? An actionable list of tasks would be perfect, but any hints are welcome.

@homersimpsons
Copy link
Collaborator

@homersimpsons Can you outline the required work to do here? An actionable list of tasks would be perfect, but any hints are welcome.

To me there is nothing to do:

That said I could also update the base docker image of the representer so everything runs on PHP8.3

@mk-mxp
Copy link
Author

mk-mxp commented Mar 7, 2024

I will mark the presenter as ready for PHP8.3, as your additions most likely won't affect any solutions soon.

For running on PHP 8.3: Use XDEBUG_MODE=off for performance reasons. I found at many places, that there is a huge impact even for small programs against having the default mode.

@homersimpsons
Copy link
Collaborator

For the record, I did upgrade the runtime for the representer to PHP8.3.

I did not try to change XDEBUG settings nor looked into the 2 normalizations I did suggest above. So I will let this issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants