Function in templates should have parameters?

[jankaifer]

I feel better if I have the parameters in template (maybe because I'm used to it from other sites). When I've been solving first problem with input I didn't knew how I'm supposed to get input. I had to look in the tester script.

[behrtam]

But shouldn't choosing a good name for parameters be part of solving the exercises?

[jankaifer]

You can always rename it 😄
Maybe not names, just some strange placeholders, but something that tells me what my function gets as input. Something like inputString or array.

[ilya-khadykin]

Fixed in #510

[jankaifer]

@m-a-ge well its not fixed yet because I fixed just one exercise. But others templates are still without parameters. If you find this a good idea then all exercises should be modified.
I don't know where to write it to let others know that new exercises should have parameters in template and to tell contributors that someone could upgrade other exercises as well.

[ilya-khadykin]

@jankaifer, got it now
I'll reopen the issue then

[jankaifer]

Thx

[jankaifer]

Hi, could someone mark this as beginner-friendly or even first-timers-only please.
Thx

[ilya-khadykin]

@jankaifer, I've added requested label.

[lilislilit]

#521 Mostly covers it, I hope :)

[jankaifer]

@lilislilit thanks for changing all exercises.
I'm wondering If this issue should be closed (because it's changed everywhere) or left open (as info for new exercises).

[lilislilit]

@jankaifer As I was told in #521 comments, PR's should be separate for each exercise, so I guess, maybe add a checklist in top comment?

[jankaifer]

@m-a-ge could you please un-merge my PR #514 because as @behrtam says in #521 there should be just one exercise per PR like in #510 (as written in contributing-guide).

(Maybe we could make one exception with this rule because it will create lot of PRs. But @behrtam is the boss here 😄 .)

[ilya-khadykin]

First of all, @lilislilit and @jankaifer thanks for working on this!
To be honest I don't want to revert #514, we can always create a new PR to improve params naming if required
And I also agree that creating PRs for each exercise can be time consuming and unnecessary

[lilislilit]

@m-a-ge I agree, I don't have that much of a preference, but it would be like...a few dozen PR's. We should come to agreement with @behrtam then.

[lilislilit]

@jankaifer I revied the list on the top, and there are far too many items there, that are already implemented. These are those that left, not that impossible(Hacktoberfest is around the corner!):

Binary Search Tree
Custom Set
Bowling
Food Chain
Bank Account
Forth
React
Compute the result for a game of Hex / Polygon
Simple Linked List(? seems like it is already done in linked-list)
Dominoes
Parallel Letter Frequency
Zipper
Pov
Spiral Matrix
Two Bucket
Complex Numbers(approved, not yet merged)
Error Handling
Markdown
Parsing a Smart Game Format string.
Write a Domain Specific Language similar to the Graphviz dot language
Go Counting
Hangman
Lens Person
Tree Building
Paasio

From these only Paasio and lenses seem like a bit pointless affairs from the python pov(non sure about the passio, though).

[ilya-khadykin]

Hacktoberfest is around the corner!

@lilislilit, should we create a separate issue for each of mentioned exercises and label them accordingly for Hacktoberfest?

Complex Numbers(approved, not yet merged)

I've merged it, thanks

[lilislilit]

@m-a-ge I am not a maintainer here, but that should be swell. I don't think guys would mind much :) C# track are in those labels up to vazoo.

[jankaifer]

@lilislilit Could you please wrote exact names of exercises?
I found just half of your list.

[sjwarner-bp]

I've just done this for the acronym.py template. I hope I did it ok, I am new to this! Please let me know if there is anything I could have done better.

[ilya-khadykin]

@jankaifer, thanks for your list. I'm creating separate issues for each of these exercises as part of Hacktoberfest.
I hope you and @lilislilit will contribute since you've committed a lot of in this.

[jankaifer]

@m-a-ge do you need help with merging PRs and closing issues?

[ilya-khadykin]

@jankaifer it definitely take some time to go through all of them, to be honest.
Do you want to become a maintainer of the track?

[jankaifer]

@m-a-ge I would love to become a maintainer.

[N-Parsons]

And I think we're done! Thanks for clearing the last few up, @cmccandless!