Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 compatibility #52

Closed
sjakobi opened this issue Apr 17, 2014 · 9 comments
Closed

Python3 compatibility #52

sjakobi opened this issue Apr 17, 2014 · 9 comments

Comments

@sjakobi
Copy link
Contributor

sjakobi commented Apr 17, 2014

While many students already solve assignments with Python3, we currently don't know which test suites actually run with Python3 and which require manual adaptation by the students.

To fix this, I propose that we (@kytrinyx?) create a new development branch "py3k" and take the following steps:

  1. Configure Travis to use Python versions 2.7, 3.3 and, once available, 3.4.
  2. Determine from the build logs which exercises have compatibility issues and fix these one by one. Both the test suites and the example implementation should be fully compatible!
  3. Change the setup recommendation to include Python3.

Once this is done it should be possible to simply replace the master branch by py3k.

@kytrinyx
Copy link
Member

Sounds like a good idea.

Once this is done it should be possible to simply replace the master branch by py3k.

The branch can be merged into master per usual, we don't need to replace master with it.

@sjakobi
Copy link
Contributor Author

sjakobi commented Apr 17, 2014

Great! I have just created the "py3k" branch (wasn't sure I could do this).

Just for clarification: I don't want to abandon Python2.7 but want to all exercises to be solvable with either Python2 or Python3.

@kytrinyx
Copy link
Member

Cool. I've updated the travis configuration to run against 2.7 and 3.3

@sjakobi
Copy link
Contributor Author

sjakobi commented Apr 17, 2014

The following exercises need to be fixed:

  • hamming
  • simple_cipher
  • pascals_triangle
  • crypto_square
  • matrix
  • trinary
  • atbash_cipher
  • pythagorean_triplet
  • hexadecimal
  • ocr
  • wordy
  • rna_transcription

@kytrinyx
Copy link
Member

Awesome progress! Thanks so much for working on this.

@sjakobi
Copy link
Contributor Author

sjakobi commented Apr 20, 2014

Thanks! Most compatibility problems are easily solved. The rest is interesting.

Basically it's all fun to me. :)

@kytrinyx
Copy link
Member

It looks like this is ready to go into master. Want to do the honors?

@sjakobi
Copy link
Contributor Author

sjakobi commented Apr 27, 2014

Seems like we can close this now that all exercises are compatible and the setup recommendations have been edited.

I'll add build testing for Python3.4 once it is available on Travis.

@sjakobi sjakobi closed this as completed Apr 27, 2014
@kytrinyx
Copy link
Member

Awesome. Thanks for taking the lead on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants