Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binary-search-tree: replace invalid uuid #1111

Merged
merged 1 commit into from
Nov 16, 2017
Merged

binary-search-tree: replace invalid uuid #1111

merged 1 commit into from
Nov 16, 2017

Conversation

cmccandless
Copy link
Contributor

Re #1096, valid uuid is X(8)-X(4)-X(4)-X(4)-X(12) where X is [\da-f]. This exercise must've been merged after #1096 or was simply missed.

@cmccandless
binary-search-tree: replace invalid uuid
2c65eb1 
Re #1096, valid uuid is [\da-f]{8}(-[\da-f]{4}){3}-[\da-f]{12}. This exercise must've been merged after #1096 or was simply missed.
@cmccandless cmccandless mentioned this pull request Nov 16, 2017
Closed
63 tasks
N-Parsons
N-Parsons approved these changes Nov 16, 2017
View reviewed changes
Copy link
Contributor

@N-Parsons N-Parsons left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was merged after - we'll have to start checking this before merging. The configlet was only recently updated to support the newer format, so some exercises currently being implemented probably have this problem.

@N-Parsons N-Parsons merged commit 9b8505a into master Nov 16, 2017
@cmccandless
Copy link
Contributor Author

@N-Parsons I actually caught this testing #1084. If #1084 is merged the check will be automatic.

@cmccandless cmccandless deleted the cmccandless-patch-4 branch November 16, 2017 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-Parsons N-Parsons N-Parsons approved these changes

Assignees

@N-Parsons N-Parsons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmccandless @N-Parsons