[Sieve]: Draft approaches #3626
Conversation
colinleach
force-pushed
the
approach-sieve
branch
from
e7dc747
to
9dc62dd
Compare
There was a problem hiding this comment.
Apologies for the delay in getting this done! Nice work -- I especially like the performance article and code. 😄
I had the usual nits -- I sorta felt like we had to remove single letter variable names, and add in a few things. But feel free to ignore these if they irritate you.
Remind me before we merge to remove the graphs and either reproduce them for the images directory .... or not. 😄 Wonder if we should provide more explanation for the code that does the slope graphing? Something to ponder a bit (but we have time on this one so.)
exercises/practice/sieve/.approaches/comprehensions/snippet.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Does this add a spurious extra space after the link? Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
To save us forgetting it later.
I didn't intend to commit this in the first place.
I'm open to suggestions, but this risks getting pretty deep into |
Somehow, the closing of the codeblocks got dropped. Added them back in, along with final typo corrections.
|
Ugh. Somehow, the backticks went missing on a lot of the code blocks, and then adding them back in created issues in the web UI. Finally had to pull it down and edit on my desktop. Hopefully, things all work now. By the looks of the preview and links, it's been fixed. I am going to merge this, and we can do a quick PR in the morning if there are lingering issues. |
Parking this here for now. I'll check it through again tomorrow, when I hope to be more awake.
Unless you get to it first (as a displacement activity?)
I've temporarily put a graph in the Performance article, to help us see what's going on. The intention is that this should be removed before merging.