-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Circular Buffer] draft approaches #3640
Conversation
Oops - I just found a blank section that I had intended to fill in later, then forgot about. |
Added `memoryview`, `buffer protocol`, `array.array` and supporting links for various things.
Overall, I liked this, and for some exercises, I do think being briefer is a good thing. I did go ahead and edit/add some things - I wanted to add more, but I think (given our timeframe) that this is going to have to do. I really wanted to implement a Maybe we can loop back to it, because it is really interesting to dig down underneath the sugar and poke at the C API. That being said, dig too far, and it becomes a shadow C track. Who says Python is only high-level? 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🌟 I am going to go ahead and merge this. Please do give it a read, and if there are any issues, I can PR something quickly to fix. But I think given the delays I caused, we should get this live to the site. 😄 Thank you so much for your hard work on this!
Only issue I can see is a bit of grammar
"A less versatile variants include' is sign of edits gone a bit wrong. Intoduction.md, line 41 |
Will submit a fix here shortly, unless you want to? |
I'm a bit distracted by other stuff this morning. You could probably do it quicker and more reliably. |
For this one I experimented with brevity to see how it looks.
What do you think - too short? Or about what this exercise deserves (in Python)?