Update dicts_test.py #3768
Update dicts_test.py #3768
Conversation
There should be another test in the first task where the list is not ordered.
Right now this function:
def create_inventory(items):
"""Create a dict that tracks the amount (count) of each element on the items list.
:param items: list - list of items to create an inventory from.
:return: dict - the inventory dictionary.
"""
new_inventory = {}
for key, item in enumerate(items):
counter = 1
new_inventory[item] = counter
if items[key] == items[key - 1]:
counter+= 1
new_inventory[item] = counter
else:
counter = 0
return new_inventory
pass and it shouldn't.
Cheers.
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
There should be another test in the first task where the list is not ordered.
Right now this function:
def create_inventory(items):
"""Create a dict that tracks the amount (count) of each element on the items list.
pass and it shouldn't.
Cheers.