Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate canonical data methods from ExerciseCase #648

Merged
merged 10 commits into from
May 31, 2017
Merged

Separate canonical data methods from ExerciseCase #648

merged 10 commits into from
May 31, 2017

Commits on May 21, 2017

  1. Remove wordy_cases_tests 

    They just cause everything to break unnecessarily.
These tests will be added back in again at the end of the refactoring.
    @Insti
    Insti committed May 21, 2017
    Configuration menu
    Copy the full SHA
    dc07550 View commit details
    Browse the repository at this point in the history

  2. inject canonical data into ExerciseCase

    @hilary @Insti
    hilary authored and Insti committed May 21, 2017
    Configuration menu
    Copy the full SHA
    fa15669 View commit details
    Browse the repository at this point in the history

  3. Rename case_data -> canonical

    @Insti
    Insti committed May 21, 2017
    Configuration menu
    Copy the full SHA
    01f7147 View commit details
    Browse the repository at this point in the history

  4. Turn canonical into an OpenStruct. 

    So we can access its properties using dot notation.
    @Insti
    Insti committed May 21, 2017
    Configuration menu
    Copy the full SHA
    a6e77a5 View commit details
    Browse the repository at this point in the history

  5. Forward canonical data methods to canonical instance variable

    @Insti
    Insti committed May 21, 2017
    Configuration menu
    Copy the full SHA
    3f5328a View commit details
    Browse the repository at this point in the history

  6. Add respond_to? method

    @Insti
    Insti committed May 21, 2017
    Configuration menu
    Copy the full SHA
    58661b5 View commit details
    Browse the repository at this point in the history

  7. Repair problematic exericses

    @Insti
    Insti committed May 21, 2017
    Configuration menu
    Copy the full SHA
    8844c7a View commit details
    Browse the repository at this point in the history

  8. Revert "Remove wordy_cases_tests" 

    This reverts commit 56192974a5b79ed45b74f9bc00bb4a77b386e40a.
    @Insti
    Insti committed May 21, 2017
    Configuration menu
    Copy the full SHA
    144d61f View commit details
    Browse the repository at this point in the history

  9. Update wordy cases and tests to use injected canonical data

    @Insti
    Insti committed May 21, 2017
    Configuration menu
    Copy the full SHA
    e08ebb2 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2017

  1. Make OpenStruct constructors use symbols.

    @Insti
    Insti committed May 31, 2017
    Configuration menu
    Copy the full SHA
    9d43bea View commit details
    Browse the repository at this point in the history