Do not intentionally exclude any exercises from the Rust test suite #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [slack](https://exercism-team.slack.com/archives/CR91YFNG3/p1602838984216700?thread_ts=1602837142.216600&cid=CR91YFNG3), `tests.toml` has these semantics: - a test whose uuid's value is `true` has been implemented in the test suite - a test whose uuid's value is `false` has been rejected by the test suite - a test whose uuid is missing from `tests.toml` is new, and has been neither approved nor rejected. Before, the assumption was that no tests in the suite were rejected. Therefore, it is not appropriate for any test to be labeled `false`. Therefore, we comment out those lines by this script: ```bash fd -uutf tests.toml -x \ sed -E -i -e '/"?[-a-zA-Z0-9]+"? = false/ { i '\#' this test may not be in the suite but has not been intentionally rejected s/^/# / }' ```
petertseng
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per slack,
tests.tomlhas these semantics:truehas been implemented in the test suitefalsehas been rejected for the test suitetests.tomlis new, and has been neitherapproved nor rejected.
Before, the assumption was that no tests in the suite were rejected.
Therefore, it is not appropriate for any test to be labeled
false.Therefore, we comment out those lines by this script:
fd -uutf tests.toml -x \ sed -E -i -e '/"?[-a-zA-Z0-9]+"? = false/ { i '\#' this test may not be in the suite but has not been intentionally rejected s/^/# / }'