-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "pending" to test suites #133
Comments
❤️ ❤️ ❤️ This is nice and actionable. Would you update the issue to include the step-by-step description of what someone would need to do to fix a single exercise? This would make a great issue for someone who wants to make their first open source contribution. |
Updated. What do you think? |
Holy smokes—this is so good. |
Glad you like. Only thing to do now is ... To open issues for the TODO item :D (I couldn't find the documentation I'm looking for) |
@ErikSchierboom - Looks good to me. There were still a handful of exercises that were not shown as completed in the task list. I double checked all of them and marked them as completed. Thanks |
👍 |
The standard in exercism is to have each test suite have all but the first test marked "pending", allowing a clean output when running the tests in a TDD fashion.
A number of the tests in the Scala track do not have that keyword. This issue tracks the exercises that still need to be updated. No checkmark means the exercise still needs to be updated.
To fix an exercise:
exercises/accumulate/src/test/scala/accumulate_test.scala
in this repository. The paths for all exercises follow a similar convention.pending
as the first line for all tests except the first one.FAQ
Q: What happens if I go to the test file and there are already
pending
keywords?A: Tell me in this issue so I can update the list!
Q: How do I edit the file and open a pull request?
A: You have two options. The simplest solution is to edit it straight in Github. This will do a number of things in the background, such as fork the repository for you and create a branch, and then allow you to open a pull request straight from there. The other option is more traditional: clone the repository locally, create a branch yourself, edit the file with your favorite editor, commit, push to your fork, then open a pull request from your fork.
TODO
Provide links to documentation on edit-and-PR through Github interface.
The text was updated successfully, but these errors were encountered: