Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "pending" to test suites #133

Closed
63 tasks done
Trevoke opened this issue Aug 29, 2016 · 12 comments
Closed
63 tasks done

Add "pending" to test suites #133

Trevoke opened this issue Aug 29, 2016 · 12 comments

Comments

@Trevoke
Copy link
Contributor

Trevoke commented Aug 29, 2016

The standard in exercism is to have each test suite have all but the first test marked "pending", allowing a clean output when running the tests in a TDD fashion.

A number of the tests in the Scala track do not have that keyword. This issue tracks the exercises that still need to be updated. No checkmark means the exercise still needs to be updated.

To fix an exercise:

  1. Choose an exercise from the list. Let us say you want to fix "accumulate".
  2. Go to the test file, which will be under the path exercises/accumulate/src/test/scala/accumulate_test.scala in this repository. The paths for all exercises follow a similar convention.
  3. Edit the file, and add the keyword pending as the first line for all tests except the first one.
  4. In your commit message, on the first line, write something like "Added pending keyword to accumulate test". In the next paragraph, write "Work on Add "pending" to test suites #133".
  5. Open a pull request and tag me ( @Trevoke ) in it, so that I can update this list when the PR gets merged in

FAQ

Q: What happens if I go to the test file and there are already pending keywords?
A: Tell me in this issue so I can update the list!

Q: How do I edit the file and open a pull request?
A: You have two options. The simplest solution is to edit it straight in Github. This will do a number of things in the background, such as fork the repository for you and create a branch, and then allow you to open a pull request straight from there. The other option is more traditional: clone the repository locally, create a branch yourself, edit the file with your favorite editor, commit, push to your fork, then open a pull request from your fork.

TODO

Provide links to documentation on edit-and-PR through Github interface.

  • Hello World
  • Bob
  • Hamming
  • Word Count
  • Pangram
  • Anagram
  • Nucleotide Count
  • Phone Number
  • Grade School
  • Robot Name
  • Leap
  • Etl
  • Meetup
  • Space Age
  • Grains
  • Gigasecond
  • Scrabble Score
  • Difference Of Squares
  • Accumulate
  • Sublist
  • Rna Transcription
  • Triangle
  • Binary
  • Roman Numerals
  • Prime Factors
  • Raindrops
  • Allergies
  • Atbash Cipher
  • Bank Account
  • Crypto Square
  • Kindergarten Garden
  • Robot Simulator
  • Queen Attack
  • Binary Search Tree
  • Hexadecimal
  • Largest Series Product
  • Luhn
  • Clock
  • Matrix
  • House
  • Minesweeper
  • Ocr Numbers
  • Octal
  • Trinary
  • Wordy
  • Food Chain
  • Linked List
  • Custom Set
  • Nth Prime
  • Palindrome Products
  • Pascals Triangle
  • Pig Latin
  • Pythagorean Triplet
  • Saddle Points
  • Say
  • Secret Handshake
  • Series
  • Sieve
  • Simple Cipher
  • Connect
  • Parallel Letter Frequency
  • Acronym
  • Forth
@kytrinyx
Copy link
Member

kytrinyx commented Sep 2, 2016

❤️ ❤️ ❤️ This is nice and actionable. Would you update the issue to include the step-by-step description of what someone would need to do to fix a single exercise? This would make a great issue for someone who wants to make their first open source contribution.

@Trevoke
Copy link
Contributor Author

Trevoke commented Sep 2, 2016

Updated. What do you think?

@kytrinyx
Copy link
Member

kytrinyx commented Sep 5, 2016

Holy smokes—this is so good.

@Trevoke
Copy link
Contributor Author

Trevoke commented Sep 7, 2016

Glad you like. Only thing to do now is ... To open issues for the TODO item :D (I couldn't find the documentation I'm looking for)

ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Oct 25, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 13, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 14, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 14, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 14, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 14, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 14, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 14, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 14, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 14, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 14, 2016
ErikSchierboom added a commit to ErikSchierboom/scala that referenced this issue Dec 14, 2016
@ErikSchierboom
Copy link
Member

@abo64 @ricemery @Trevoke I think this issue has been resolved. Could someone check?

@ricemery
Copy link
Member

@ErikSchierboom - Looks good to me. There were still a handful of exercises that were not shown as completed in the task list. I double checked all of them and marked them as completed.

Thanks

@ErikSchierboom
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants