-
-
Notifications
You must be signed in to change notification settings - Fork 133
Add Yacht exercise to the Scala track #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
@ErikSchierboom Could you please take a look at this pull request? I did not build, run or locally tested anything, since I did not find any guide about how to do any of these, so this PR may need further change. At least I know the I mainly copied the stuff from the F# Yacht problem and translated everything into Scala 2. |
configlet fails with:
You should add an entry for this exercise to the I'd also recommend update the tests, metadata and docs with the latest version: All in all this is a great PR! |
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Done these steps! When running |
@ErikSchierboom I have updated this pr according to your comments. Please take a look again, thanks. |
Are you sure? configlet expects |
I did not run it in the root, I ran it inside the Okay, I'll redo the last commit. |
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
I have updated this pr according to your latest comments. Please take a look. @ErikSchierboom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The CI tests failed. I'll work on fixing my errors. |
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
I have changed my implementation and run the tests locally and they passes. Can you start the workflow again to see if the CI tests pass this time? @ErikSchierboom |
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
I fixed my error of the wrong class name. Could you please start the CI test again? Thanks. @ErikSchierboom |
Thanks! |
Per my discussion thread on the exercism forum.