Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#139 Clock exercise improvements #140

Merged
merged 1 commit into from
Apr 7, 2016
Merged

#139 Clock exercise improvements #140

merged 1 commit into from
Apr 7, 2016

Conversation

robtimp
Copy link
Contributor

@robtimp robtimp commented Apr 7, 2016

Implement changes to Clock exercises and test from Issue #139.

Conformance to comparable is no longer required for tests and has been removed.

@robtimp robtimp changed the title #166 Clock exercise improvements #139 Clock exercise improvements Apr 7, 2016
@robtimp
Copy link
Contributor Author

robtimp commented Apr 7, 2016

@masters3d

masters3d
masters3d reviewed Apr 7, 2016
View reviewed changes
exercises/clock/ClockExample.swift
self.hours += 24
}
}

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why, I prefer to have extensions and global function on the top of the file.

@masters3d
Copy link
Contributor

Looks good!

@masters3d masters3d merged commit 90a2dab into exercism:master Apr 7, 2016
@robtimp robtimp mentioned this pull request Apr 8, 2016
Closed
@masters3d
Copy link
Contributor

There is a cool little feature I just learned about Github PR:
You can add something like close #139 in the commit message and once merged it will automatically will close the issue.
https://help.github.com/articles/closing-issues-via-commit-messages/

@robtimp robtimp deleted the issue-139 branch April 8, 2016 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robtimp @masters3d