Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clock: canonical test data has been improved #139

Closed
kytrinyx opened this issue Apr 7, 2016 · 1 comment
Closed

clock: canonical test data has been improved #139

kytrinyx opened this issue Apr 7, 2016 · 1 comment

Comments

@kytrinyx
Copy link
Member

kytrinyx commented Apr 7, 2016

The JSON file containing canonical inputs/outputs for the Clock exercise has gotten new data.

There are two situations that the original data didn't account for:

  • Sometimes people perform computation/mutation in the display method instead of in add. This means that you might have two copies of clock that are identical, and if you add 1440 minutes to one and 2880 minutes to the other, they display the same value but are not equal.
  • Sometimes people only account for one adjustment in either direction, meaning that if you add 1,000,000 minutes, then the clock would not end up with a valid display time.

If this track has a generator for the Clock exercise, go ahead and regenerate it now. If it doesn't, then please verify the implementation of the test suite against the new data. If any cases are missing, they should be added.

See exercism/problem-specifications#166

masters3d added a commit that referenced this issue Apr 7, 2016
@robtimp
Copy link
Contributor

robtimp commented Apr 8, 2016

Resolved by pull request #140.

@robtimp robtimp closed this as completed Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants