Skip to content
This repository was archived by the owner on Jan 17, 2019. It is now read-only.

Use Implementation#merge_files instead of files= #151

Closed
wants to merge 2 commits into from
Closed

Use Implementation#merge_files instead of files= #151

wants to merge 2 commits into from

Conversation

Insti
Copy link
Contributor

@Insti Insti commented Apr 22, 2017

Use merge_files method rather than the deprecated files= method when adding the solution files to the implementation file bundle.

Silences deprecation warning.

Requires trackler update

Dependency: exercism/DEPRECATED.trackler#39

@Insti Insti mentioned this pull request Apr 22, 2017
Merged
@Insti
Trigger Travis.
e18ccbb 
This is an empty commit to trigger travis to re-check this PR since
trackler has been updated to include the `merge_files` method.
@kytrinyx
Copy link
Member

The build is failing with

 1) Error:
V1RoutesExercisesTest#test_restore_exercises_and_solutions:
NoMethodError: undefined method `merge_files' for #<Trackler::Implementation:0x00000003b529c8>

@Insti
Copy link
Contributor Author

Insti commented May 23, 2017

Hmm github didn't notify me about this. :/

Looks like @kytrinyx fixed did the same fix in #153 anyway.

@Insti Insti closed this May 23, 2017
@Insti Insti deleted the Use_Implementation#merge_files branch May 23, 2017 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Insti @kytrinyx