Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Resources > Contributing to Express #1507

Merged
merged 1 commit into from
May 3, 2024
Merged

Update Resources > Contributing to Express #1507

merged 1 commit into from
May 3, 2024

Conversation

crandmck
Copy link
Member

@crandmck crandmck commented May 2, 2024 •
edited
Loading

https://expressjs.com/en/resources/contributing.html reproduces the content of these files by running get-contributing.sh:

Several of these files have been updated recently and I realized that we've been negligent in updating this page.

@crandmck crandmck requested a review from a team May 2, 2024 05:29
@crandmck crandmck mentioned this pull request May 2, 2024
Closed
UlisesGascon
UlisesGascon approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crandmck crandmck merged commit 52f91fb into gh-pages May 3, 2024
3 checks passed
@bjohansebas bjohansebas deleted the contrib-guide branch October 22, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@jonchurch jonchurch jonchurch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crandmck @UlisesGascon @jonchurch