Skip to content

Conversation

@ayrat555
Copy link
Member

fixes #11

@ayrat555 ayrat555 requested review from hayesgm and masonforest April 30, 2018 17:44
Copy link

@masonforest masonforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@masonforest masonforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hayesgm hayesgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dig the custom encodes!

@ayrat555
Copy link
Member Author

@hayesgm @masonforest one more review please. rewrote encoding using only protocols

@ayrat555 ayrat555 merged commit 799c7ca into mana-ethereum:master May 1, 2018
@ayrat555 ayrat555 deleted the get-rid-of-protocol-for-map branch May 1, 2018 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

protocols for Map overrides protocols for other structs

3 participants