Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use editing keyboard shortcuts on tagless nodes with v2.2 #1265

Closed
mxxcon opened this issue Dec 20, 2023 · 6 comments · Fixed by #1267
Closed

Can't use editing keyboard shortcuts on tagless nodes with v2.2 #1265

mxxcon opened this issue Dec 20, 2023 · 6 comments · Fixed by #1267
Labels
bug-regression It worked before but now it doesn't
Milestone

Comments

@mxxcon
Copy link

mxxcon commented Dec 20, 2023

Description

I'm not sure if it's a bug or a feature, but keyboard shortcuts are not working because windows focus automatically gets locked to the search box.
For example if I draw a line, add a node to it, i can't use X shortcut to split it

Screenshots

image

Version

2.2.0

What browser are you seeing the problem on? What version are you running?

Chrome v121.0

The OS you're using

win

Steps to reproduce

  1. Draw a sidewalk
  2. Add a node to it
  3. Try to use X shortcut it split it

The browser URL at the time you encountered the bug

https://rapideditor.org/edit?#background=EsriWorldImagery&datasets=fbRoads,msBuildings&disable_features=buildings,boundaries&gpx=https://mwai-tasking-manager-production-api.mapwith.ai/api/v2/projects/149/tasks/queries/gpx/%3Ftasks%3D375&map=20.97/40.59033/-73.92740

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36

@mxxcon
Copy link
Author

mxxcon commented Dec 20, 2023

Also can't delete a tagless node or disconnect 2 ways on the intersection of a tagless node with D

@Bonkles
Copy link
Contributor

Bonkles commented Dec 21, 2023

Okay, I have run a git bisect for all 120+ commits since tag 2.1 and found the commit where this got introduced.

It was commit c308af25e705ac226d6ce6e85fbbd400c66cdd9e, where we made a fix for the walkthrough in #1236.

Now investigating root cause.

@Bonkles
Copy link
Contributor

Bonkles commented Dec 21, 2023

In addition to hogging the focus, it looks like the search input isn't being cleared between selections. This is likely related. Normally when you pick a preset the search input is cleared, but it appears this is not the case either:

bug_1265.mov

@bhousel bhousel added the bug-regression It worked before but now it doesn't label Dec 21, 2023
Bonkles added a commit that referenced this issue Dec 21, 2023
…es, and also clearing the input after a selection.
@Bonkles Bonkles linked a pull request Dec 21, 2023 that will close this issue
Bonkles added a commit that referenced this issue Dec 21, 2023
…es, and also clearing the input after a selection. (#1267)
@bos
Copy link

bos commented Dec 22, 2023

Is this fix live?

@bhousel
Copy link
Contributor

bhousel commented Dec 22, 2023

Is this fix live?

I believe you can try it in https://rapideditor.org/canary right now..
I'll push a patch to the main Rapid site soon that includes fixes for this and the other issue @mxxcon found.

@bhousel
Copy link
Contributor

bhousel commented Dec 22, 2023

Thanks for the report @mxxcon & @bos , and shout out to @Bonkles for the quick fix.
I just published a v2.2.1 patch release to rapideditor.org that includes this fix.

@bhousel bhousel added this to the 2.2.1 milestone Dec 22, 2023
bhousel added a commit that referenced this issue Jan 5, 2024
re: #1265, re: #1267

This is another situation where we expect the focus to be on the input field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-regression It worked before but now it doesn't
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants