Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[docs] Fix instructions for Java install with Homebrew #2611

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

narlei
Copy link
Contributor

@narlei narlei commented Apr 13, 2021

The current doc use homebrew/cask-cask instructions, and cask was changed.

The current instructions to install java with Homebrew doesn't work, and mysteriously it requests your github email and password 🤔🏴‍☠️.
This PR change the docs to install java using https://github.com/AdoptOpenJDK/homebrew-openjdk with correct cask command in homebrew.

@KapJI
Copy link
Member

KapJI commented Apr 13, 2021

Not sure why CI is not triggered :(
Can you try to force push to trigger it?

@Lcsmarcal
Copy link
Contributor

Lcsmarcal commented Apr 13, 2021

@KapJI It's happening with another PRs too :(

@narlei
Copy link
Contributor Author

narlei commented Apr 14, 2021

I tried force push but still not triggering the CI. As @Lcsmarcal says, It's happening with other PRs too.

@KapJI
Copy link
Member

KapJI commented Apr 14, 2021

Might be related to https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

@narlei
Copy link
Contributor Author

narlei commented Apr 14, 2021

Thank you @KapJI

The complete guide:

The solution for circle-ci checks not running in PRs:
https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

By steps:

1 - Go to Signup - CircleCI and sign up with your Github account.
2 - Will be listed all your repos, go to your buck fork, if you are following it, a button “Unfollow” will be showed, just Unfollow and jump to step 5, if not, a “Set Up Project“ button appears, let’s Set Up.
3 - After Setup the project, go back to the “Projects” page (https://app.circleci.com/projects/project-dashboard/github/YOUR_USERNAME_HERE/)
4 - Just Unfollow the project.
5 - Go to https://app.circleci.com/pipelines/github/facebook/buck
6 - At the right bottom screen will appear a “Follow project” button, just follow.
7 - Give a push —force in your project fork.
Done, go to https://app.circleci.com/pipelines/github/facebook/buck and see your PR running.

@KapJI
Copy link
Member

KapJI commented Apr 14, 2021

@narlei Thanks a lot for figuring this out! CircleCI is very confusing.

We probably should migrate to Github Actions but these CI definitions are large and we need someone to do that.

@KapJI KapJI merged commit 3834803 into facebook:master Apr 14, 2021
shepting pushed a commit to airbnb/buck that referenced this pull request Nov 11, 2021
* Fix docs for java install with homebrew

* Fix docs for java install with homebrew; Try to force CI trigger
shepting pushed a commit to airbnb/buck that referenced this pull request Nov 12, 2021
* Fix docs for java install with homebrew

* Fix docs for java install with homebrew; Try to force CI trigger
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants