Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fsevents to 1.1.2 #2550

Merged
merged 1 commit into from Jun 18, 2017

Conversation

Projects
None yet
5 participants
@josephfrazier
Copy link
Contributor

commented Jun 16, 2017

This eliminates a yarn warning on OSX machines running Node.js 8. See
here for details: fsevents/fsevents#170

You can see an example of the warning in the second screenshot in
#2422 (comment)

I verified this by running:

npm run create-react-app my-app
cd my-app
yarn
Upgrade fsevents to 1.1.2
This eliminates a `yarn` warning on OSX machines running Node.js 8. See
here for details: fsevents/fsevents#170

You can see an example of the warning in the second screenshot in
#2422 (comment)

@josephfrazier josephfrazier force-pushed the josephfrazier:fsevents-1.1.2 branch to 8deb823 Jun 16, 2017

@josephfrazier

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2017

The AppVeyor failure appears to be unrelated, and it happened to another PR as well.

@abdellah-el-mennani

This comment has been minimized.

Copy link

commented Jun 18, 2017

when using create-react-app I have the following issue, and I couldn't start the project:

warning fsevents@1.1.2: The platform "win32" is incompatible with this module.
info "fsevents@1.1.2" is an optional dependency and failed compatibility check. Excluding it from installation.
@Timer

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2017

Great, thanks for this @josephfrazier!

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2017

@abdellah-el-mennani if that error shown is all you see, it can be ignored as it is a warning and is an optional dependency. Windows does not support fsevents, which is specific to macOS.

@Timer Timer added the tag: internal label Jun 18, 2017

@Timer Timer merged commit acb1957 into facebook:master Jun 18, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Timer Timer added this to the 1.0.8 milestone Jun 18, 2017

@josephfrazier josephfrazier deleted the josephfrazier:fsevents-1.1.2 branch Jun 18, 2017

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

Any ideas why this still doesn't fix CI for Node 8?
#2659 (comment)

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Upgrade fsevents to 1.1.2 (facebook#2550)
This eliminates a `yarn` warning on OSX machines running Node.js 8. See
here for details: fsevents/fsevents#170

You can see an example of the warning in the second screenshot in
facebook#2422 (comment)

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Upgrade fsevents to 1.1.2 (#2550)
This eliminates a `yarn` warning on OSX machines running Node.js 8. See
here for details: fsevents/fsevents#170

You can see an example of the warning in the second screenshot in
facebook/create-react-app#2422 (comment)

hysan added a commit to hysan/instructor-code-challenge that referenced this pull request Feb 22, 2018

Upgraded react-scripts dependency to the latest v1.1.1.
This fixes the following error on macOS with regards to and fsevents@1.0.17 not being found when using Node.js 8+. See issues and pull requests: facebook/create-react-app#2613 facebook/create-react-app#2550 fsevents/fsevents#170 fsevents/fsevents#169.

A minimum verison of v1.0.8 is required as the PR was pushed in that release: https://github.com/facebook/create-react-app/releases/tag/v1.0.8

Considering the targeted nature of the project, I figured that upgrading to the latest (v1.1.1) would be safe.

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.