Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local testing docker links #2662

Merged
merged 2 commits into from Jun 28, 2017

Conversation

Projects
None yet
3 participants
@EnoahNetzach
Copy link
Contributor

commented Jun 28, 2017

I've added a link to Docker's installation docs, as requested in #2408 (comment).

@gaearon gaearon added this to the 1.0.8 milestone Jun 28, 2017

@gaearon gaearon merged commit 60ae2b6 into facebook:master Jun 28, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

Tx

@EnoahNetzach EnoahNetzach deleted the EnoahNetzach:local-testing-docker branch Jun 28, 2017

@EnoahNetzach

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2017

did it work?

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

Have not tried yet, will some time!

@EnoahNetzach

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2017

Let me know if you have any problems

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

zangrafx added a commit to absolvent/create-react-app that referenced this pull request Jun 29, 2017

Merge remote-tracking branch 'upstream/master'
* upstream/master: (55 commits)
  Fix minor typo (facebook#2679)
  Bootstrap with Yarn when available (facebook#2673)
  Add more info about apache client side routing (facebook#2666)
  Test Node 8 on Travis (facebook#2659)
  Add json and css to lint-staged in template README (facebook#2671)
  Add a note about fixed vulnerability in 1.0.8
  Publish
  Changelog for 1.0.8 (facebook#2664)
  Reformat source code with Prettier 1.5.2
  Update Prettier to v1 (facebook#2465)
  Update ISSUE_TEMPLATE.md
  Local testing docker links (facebook#2662)
  Better React Native Web support (facebook#2511)
  Bump dependencies (facebook#2658)
  Minor code style edits to user guide (facebook#2660)
  Don't ask to install webpack for using Styleguidist (facebook#2656)
  Put react-scripts in dependencies, not devDependencies (facebook#2657)
  Razzle added to the alternatives (facebook#2517)
  Warn about large bundle sizes (facebook#2648)
  Add instructions to use source-map-explorer (facebook#1641)
  ...

# Conflicts:
#	packages/react-dev-utils/package.json
#	packages/react-scripts/config/webpack.config.dev.js
#	packages/react-scripts/config/webpack.config.prod.js
#	packages/react-scripts/package.json

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Local testing docker links (facebook#2662)
* Fix a command style in docs

* Add a link to docker's docs

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Local testing docker links (#2662)
* Fix a command style in docs

* Add a link to docker's docs

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

Local testing docker links (facebook#2662)
* Fix a command style in docs

* Add a link to docker's docs

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.