Put react-scripts in dependencies, not devDependencies #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty sure this works. |
Merged
zangrafx
added a commit
to absolvent/create-react-app
that referenced
this pull request
Jun 29, 2017
* upstream/master: (55 commits) Fix minor typo (facebook#2679) Bootstrap with Yarn when available (facebook#2673) Add more info about apache client side routing (facebook#2666) Test Node 8 on Travis (facebook#2659) Add json and css to lint-staged in template README (facebook#2671) Add a note about fixed vulnerability in 1.0.8 Publish Changelog for 1.0.8 (facebook#2664) Reformat source code with Prettier 1.5.2 Update Prettier to v1 (facebook#2465) Update ISSUE_TEMPLATE.md Local testing docker links (facebook#2662) Better React Native Web support (facebook#2511) Bump dependencies (facebook#2658) Minor code style edits to user guide (facebook#2660) Don't ask to install webpack for using Styleguidist (facebook#2656) Put react-scripts in dependencies, not devDependencies (facebook#2657) Razzle added to the alternatives (facebook#2517) Warn about large bundle sizes (facebook#2648) Add instructions to use source-map-explorer (facebook#1641) ... # Conflicts: # packages/react-dev-utils/package.json # packages/react-scripts/config/webpack.config.dev.js # packages/react-scripts/config/webpack.config.prod.js # packages/react-scripts/package.json
romaindso
pushed a commit
to romaindso/create-react-app
that referenced
this pull request
Jul 10, 2017
* Put react-scripts in dependencies, not devDependencies * Sort dependencies on eject * Remove CI check
wmonk
referenced
this pull request
in wmonk/create-react-app-typescript
Aug 7, 2017
* Put react-scripts in dependencies, not devDependencies * Sort dependencies on eject * Remove CI check
morgs32
pushed a commit
to BrickworkSoftware/create-react-app
that referenced
this pull request
Sep 1, 2017
* Put react-scripts in dependencies, not devDependencies * Sort dependencies on eject * Remove CI check
bjoernricks
added a commit
to greenbone/gsa
that referenced
this pull request
Oct 26, 2017
src/html/classic/ng/yarn.lock: Update react-script (from create-react-app) to latest release (1.0.10) and put it into dependenciesi (details: facebook/create-react-app#2657). Remove other devdependencies which aren't necessary anymore. They have been added due to a bug in eslint for validating in external editors. git-svn-id: svn+ssh://scm.wald.intevation.org/openvas/trunk/gsa@29027 423fd1db-d629-0410-8442-d21db03e70f4
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The distinction doesn't fully make sense in React world because you need both types to bundle the app, and neither on the server. It also created problems for folks who run build on deployment. It is also inconsistent (for example promise polyfill is technically a runtime dependency but was treated as a build one). Fixes #2655 as well.